LF-4690 Create POST endpoint to create an Ensemble addon #3655
+171
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for readability Remove reduce in favour of more readable array methods; encapsulate all three Ensemble methods into one function; define a constant for 'Ensemble Scientific'
…adability Remove unused returned values from registerOrganizationWebhook; un-nest code run when function does not return early; add comments to make more explicit how bulkSensorClaim response is defined from Ensemble API response
…n via organization_uuid
kathyavini
requested review from
antsgar and
Duncan-Brain
and removed request for
a team
kathyavini
commented
Jan 16, 2025
…rom Loic's screens
|
With the move towards the farm-wide "add-on" concept (and confirmation we're sticking with sending only organization_uuid), I'm now more inclined to let this be a POST to something like Otherwise I think "linking" and "unlinking" should l be the wording used now (to match the views) so I have made that change in the meantime. |
For now it will 400 if not Ensemble so we don't fill this table with records we can't use
This reverts commit 8503f81.
kathyavini
changed the base branch from
integration
to
LF-4625-readability-refactors
kathyavini
changed the base branch from
LF-4625-readability-refactors
to
integration
kathyavini
changed the title
kathyavini
changed the base branch from
integration
to
LF-4625-readability-refactors
kathyavini
changed the base branch from
LF-4625-readability-refactors
to
integration
Duncan-Brain
previously approved these changes
Jan 29, 2025
SayakaOno
approved these changes
Jan 30, 2025
Duncan-Brain
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the controller to link an Ensemble organization to a LiteFarm farm. You can send a different
addon_partner_idif you like, but you'll get back a 400.POST to
/farm_addonRequest body:
{ "addon_partner_id": 1, "org_uuid": "ensemble-organisation-uuid"Jira link: https://lite-farm.atlassian.net/browse/LF-4690
Type of change
How Has This Been Tested?
Test in postman
Checklist: