feat(api): enforce request and response schema validation#91
Open
Elite-tch wants to merge 2 commits intoLiquifact:mainfrom
Open
feat(api): enforce request and response schema validation#91Elite-tch wants to merge 2 commits intoLiquifact:mainfrom
Elite-tch wants to merge 2 commits intoLiquifact:mainfrom
Conversation
|
@Elite-tch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Sorry for late PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: feat(api): enforce request and response schema validation (#21)
Closes #21
This PR implements strict API boundary validation to prevent silent schema drift and accidental contract regressions.
Changes:
Zod Schemas: Added comprehensive input/output schemas in src/schemas/apiSchemas.js.
Validation Middleware: Implemented validateRequest for inbound payload verification (returns 400 Bad Request) and an outgoing interceptor validateResponse(returns 500 Internal Server Error to prevent internal data leakage).
Endpoint Security: Applied schemas alongside missing authenticateToken / sensitiveLimiter checks to all core src/index.js endpoints.
Tests: Authored validate.test.js to cover mismatch scenarios and refactored underlying bugs in the legacy
auth and index.js tests to pass correctly.
Code coverage is confidently above 95%.
Docs: Appended API Boundary Validation documentation to README.md .