feat(api): add TTL cache for escrow read endpoint#88
Open
okekefrancis112 wants to merge 6 commits intoLiquifact:mainfrom
Open
feat(api): add TTL cache for escrow read endpoint#88okekefrancis112 wants to merge 6 commits intoLiquifact:mainfrom
okekefrancis112 wants to merge 6 commits intoLiquifact:mainfrom
Conversation
|
@okekefrancis112 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
npm ci was failing because the lockfile was missing entries for jsonwebtoken and its transitive dependencies.
Contributor
|
Resolve the conflicts & revert the changes in package-lock.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #27
MemoryCacheStoreabstraction (src/services/cacheStore.js) backed by nativeMapwith TTL-based lazy eviction, designed for future Redis swap-incacheResponseExpress middleware (src/middleware/cache.js) that interceptsres.json()to cache 2xx responses, setsX-Cache: HIT/MISSheaders, and transparently falls through on cache errorssrc/config/cache.js) parsingESCROW_CACHE_TTL_SECONDSenv var (default: 30s)GET /api/escrow/:invoiceIdrouteMap