feat(api): Guarded Invoice PATCH Endpoint#80
Open
simplicityf wants to merge 3 commits intoLiquifact:mainfrom
Open
feat(api): Guarded Invoice PATCH Endpoint#80simplicityf wants to merge 3 commits intoLiquifact:mainfrom
simplicityf wants to merge 3 commits intoLiquifact:mainfrom
Conversation
…-level access controls
|
@simplicityf Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Resolve the conflicts & revert the changes in package-lock.json |
Author
Author
|
@mikewheeleer kindly review |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
PATCH /api/invoices/:idwith strict field-level access controls and status-aware edit permissions.Why
Invoice records contain financially sensitive fields (
amount,customer) that must become immutable once they enter the verification/funding pipeline. Without this guard, any authenticated caller could silently overwrite committed values or spoof system-managed fields likestatusandid.How
A dedicated middleware (
middleware/patchInvoice.js) owns all guard logic and is independently unit-tested:amount,customer, andnotesare ever writable; all other keys are stripped before any write occurs.amountandcustomerare rejected with422once the invoice status isverified,funded,settled, orcancelled;notesremains editable throughout.409if the invoice has been soft-deleted; caller must restore first.Test coverage
42 tests,
middleware/patchInvoice.jsat 100% statement / branch / function / line coverage.Security notes
MUTABLE_FIELDSallowlist; unknown keys discarded before writestatusnot in allowlist; only a dedicated transition endpoint can change itObject.prototype.hasOwnProperty.callguards throughout409guard; restore required before updateChecklist
Related Issue
Closes #24
Screenshot