Upgrade deps - #13
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project to newer wgpu/glam versions and adjusts code/examples/docs to match the updated wgpu::Instance initialization API, while also removing a “breaking changes” warning from the README.
Changes:
- Upgrade
wgputo29.0andglamto0.32, updating call sites to the newwgpu::Instance::new(...)/InstanceDescriptorusage. - Update examples, doctests, and test context initialization for headless-friendly instance creation.
- Remove the active-development warning block from
README.md.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/common/test_context.rs | Updates test wgpu::Instance creation to the new descriptor API. |
| src/selection.rs | Updates rustdoc example code to new wgpu::Instance construction. |
| src/selection_modifier.rs | Updates rustdoc example code to new wgpu::Instance construction (two locations). |
| src/modifier.rs | Updates rustdoc example code to new wgpu::Instance construction. |
| examples/modify.rs | Updates example wgpu::Instance creation to new descriptor API. |
| examples/modify_selection.rs | Updates example wgpu::Instance creation to new descriptor API. |
| examples/filter_selection.rs | Updates example wgpu::Instance creation to new descriptor API. |
| examples/custom_modify_selection.rs | Updates example wgpu::Instance creation to new descriptor API. |
| README.md | Removes the breaking-changes warning callout. |
| Cargo.toml | Bumps wgpu/glam versions; switches wgpu-3dgs-core to a Git dependency. |
| Cargo.lock | Lockfile updates reflecting dependency upgrades and the Git-sourced core crate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wgputo 29.0 andglamto 0.32, and a few other internal ones