[codex] Expose CycleAwareCircuit hierarchical Design accessor#64
Draft
zhoubot wants to merge 1 commit into
Draft
[codex] Expose CycleAwareCircuit hierarchical Design accessor#64zhoubot wants to merge 1 commit into
zhoubot wants to merge 1 commit into
Conversation
Downstream hierarchical build integrations need the compiled Design object, but reaching into _v5_design couples them to a private implementation field. CycleAwareCircuit now exposes a read-only public property that returns the hierarchical Design when present and None for flat circuits. Constraint: The accessor must not create or mutate hierarchy state. Rejected: Keep downstream code on _v5_design | that preserves a private API dependency in integration flows. Confidence: high Scope-risk: narrow Tested: PYTHONPATH=compiler/frontend pytest -q tests/unit/test_v5_state_signal.py
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new hierarchical_design property to the CycleAwareCircuit class, providing public access to the underlying design object for hierarchical circuits while returning None for flat ones. This change allows downstream integrations to access the design without depending on private implementation fields. Unit tests have been added to verify this behavior in both scenarios. I have no feedback to provide as no review comments were present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #57.
Adds a public
CycleAwareCircuit.hierarchical_designproperty so downstream hierarchical integrations can read the compiledDesignobject without depending on the private_v5_designfield. Flat circuits returnNone.Validation
PYTHONPATH=compiler/frontend pytest -q tests/unit/test_v5_state_signal.py