readlink and readlinkat implementation on RawPOSIX / Wasmtime / glibc #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaxuan-w
requested review from
rennergade,
ChinmayShringi,
yzhang71,
qianxichen233 and
robinyuan1002
There was a problem hiding this comment.
Have a few doubts but overall looks good to me. Also a reminder to @ChinmayShringi , once this PR is merged, we need to also add address checking for the two new syscalls we have here in current memory PR or a seperate PR, depends on whether this PR or the memory PR merges first
rennergade
reviewed
Jan 6, 2025
rennergade
reviewed
Jan 6, 2025
m-hemmings
reviewed
Jan 6, 2025
m-hemmings
reviewed
Jan 6, 2025
This was referenced Jan 7, 2025
rennergade
reviewed
Jan 30, 2025
rennergade
approved these changes
Feb 6, 2025
qianxichen233
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for readlink and readlinkat in lind-wasm to address issues encountered during Python compilation.
Changes:
RawPOSIX:
readlinkandreadlinkatalong with necessary path resolution logic.glibc:
readlinkatfromreadlinkif the latter was not fully implemented. Since both syscalls are now implemented separately, the conditional check has been removed.Tests:
readlinkandreadlinkat to ensure proper functionality.