glibc - clone_fallback compile issue #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Lets leave this PR up for now and open up an issue. At the very least if we do merge we need to add comments saying that we removed this and why. |
Contributor
|
I looked further into this and I think its fine to remove the function if its doing weird things when compiling, its only there to support systems that don't do clone3 and we do. It's only called once in spawni if clone3 returns ENOSYS, we should probably add some sort of panic there if we got into a situation where it was somehow called. We definitely need to add comments here explaining as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is splited from PR #164
This PR focuses on spliting out the fix for
__clone_internal_fallbackfunction.This could probably better be an issue rather a PR.
There is a weird bug on
__clone_internal_fallback: when compiling some large applications, the generated wasm binary code at__clone_internal_fallbackis incorrect and made the entire wasm binary unable to run. I currently havn't figured out if this is a bug fromclangor it's due to something else. This is a very brutal temporary solution that directly removed the body of this function, this workaround at least made the compiled binary be able to run.