-
Notifications
You must be signed in to change notification settings - Fork 5
delete getifaddrs #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete getifaddrs #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a description explaining the purpose of this change, where we previously discussed it? This will help provide context for future reference and make it clear why this modification was made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there is also getifaddrs
test case in rawposix that should be deleted together. Specifically,
pub fn ut_lind_net_getifaddrs() { |
Should this eventually get converted to an integration test where we actually run an app which calls this glibc function? |
We've had that already: https://github.com/Lind-Project/lind-wasm/blob/main/tests/unit-tests/config_tests/non-deterministic/getifaddrs.c |
@rennergade this PR is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should also get rid of the gen_netdevs files and the getifaddrs_from_file function in comm.rs even though its currently commented out.
FYI: gen_netdevs files files should locate on
|
It seems like there are no getifaddrs_from_file function in comm.rs. |
We can merge this once @qianxichen233 approves his change requests |
When I tried to fix the issue 20, I found out that getifaddrs is not a syscall but a glibc function instead. According to our disscussion, we decided to delete getifaddrs from Rawposix and handle rest of mechanism through fixing sockaddr data structure, which has been mentioned in issue #42