Skip to content

delete getifaddrs #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025
Merged

delete getifaddrs #101

merged 3 commits into from
Feb 10, 2025

Conversation

robinyuan1002
Copy link
Collaborator

@robinyuan1002 robinyuan1002 commented Feb 5, 2025

When I tried to fix the issue 20, I found out that getifaddrs is not a syscall but a glibc function instead. According to our disscussion, we decided to delete getifaddrs from Rawposix and handle rest of mechanism through fixing sockaddr data structure, which has been mentioned in issue #42

Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a description explaining the purpose of this change, where we previously discussed it? This will help provide context for future reference and make it clear why this modification was made.

Copy link
Contributor

@qianxichen233 qianxichen233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is also getifaddrs test case in rawposix that should be deleted together. Specifically,

pub fn ut_lind_net_getifaddrs() {

@JustinCappos
Copy link
Member

I believe there is also getifaddrs test case in rawposix that should be deleted together. Specifically,

pub fn ut_lind_net_getifaddrs() {

Should this eventually get converted to an integration test where we actually run an app which calls this glibc function?

@Yaxuan-w
Copy link
Member

Yaxuan-w commented Feb 7, 2025

Should this eventually get converted to an integration test where we actually run an app which calls this glibc function?

We've had that already: https://github.com/Lind-Project/lind-wasm/blob/main/tests/unit-tests/config_tests/non-deterministic/getifaddrs.c

@robinyuan1002
Copy link
Collaborator Author

@rennergade this PR is ready to merge.

Copy link
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should also get rid of the gen_netdevs files and the getifaddrs_from_file function in comm.rs even though its currently commented out.

@Yaxuan-w
Copy link
Member

Yaxuan-w commented Feb 7, 2025

FYI: gen_netdevs files files should locate on

src/RawPOSIX/gen_netdevs.c
src/RawPOSIX/gen_netdevs.sh

@robinyuan1002
Copy link
Collaborator Author

I believe we should also get rid of the gen_netdevs files and the getifaddrs_from_file function in comm.rs even though its currently commented out.

It seems like there are no getifaddrs_from_file function in comm.rs.

@rennergade
Copy link
Contributor

We can merge this once @qianxichen233 approves his change requests

@rennergade rennergade merged commit 4450442 into main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants