Skip to content

Support custom simple block tags #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 11, 2025
Merged

Support custom simple block tags #128

merged 18 commits into from
Oct 11, 2025

Conversation

@LilyFirefly
Copy link
Owner

No description provided.

@LilyFirefly LilyFirefly self-assigned this Sep 22, 2025
@LilyFirefly LilyFirefly added enhancement New feature or request refactor labels Sep 22, 2025
@codecov
Copy link

codecov bot commented Sep 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.63107% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/parse.rs 92.40% 0 Missing and 12 partials ⚠️
src/render/tags.rs 94.69% 0 Missing and 6 partials ⚠️

📢 Thoughts on this report? Let us know!

@LilyFirefly LilyFirefly force-pushed the custom-simple-block-tags branch 2 times, most recently from c3b0a11 to e4e40be Compare September 22, 2025 13:50
@LilyFirefly LilyFirefly force-pushed the custom-simple-block-tags branch 4 times, most recently from fd37db5 to 4045595 Compare October 2, 2025 20:22
@LilyFirefly
Use Cow<'static, str> instead of &'static str for end tag names
d361a8e 
This will allow using dynamic end tag names (i.e. for custom tags)
without needing to allocate a `String` for a known-at-compile-time end
tag name.
@LilyFirefly
Move custom tag tests to only cover simple custom tags
3407f9b
@LilyFirefly
Extract context wrangling into helper functions
f906ccd 
This will allow re-use in `SimpleBlockTag`.
@LilyFirefly
Rename TagContext::SimpleTag to TagContext::Simple
f846af9
@LilyFirefly
Make call_tag a standalone function
efa5460 
This will allow it to be used in `SimpleBlockTag::render` in addition
to `SimpleTag::render`.
@LilyFirefly
Split handling of defaults for custom tags into helper functions
9891ea6
@LilyFirefly
Implement custom simple block tags
41c4d77
@LilyFirefly
Add error handling for missing context and/or content
b12279d
@LilyFirefly
Test simple_block_tag with context and end_name
28ff376
@LilyFirefly
Test missing/only end tag for simple_block_tag
69f5aad
@LilyFirefly
Test invalid argument handling within custom simple block
b53d2a2
@LilyFirefly
Refactor handling of missing variables in custom tags
3cf6617 
A missing variable should be treated as an empty string and passed
through to the custom tag.
@LilyFirefly
Extract build_kwargs helper function for custom tags
0440ad3
@LilyFirefly
Test PartialEq for SimpleBlockTag
a3fff57
@LilyFirefly
Test syntax error within custom block tag
4200cb7
@LilyFirefly LilyFirefly force-pushed the custom-simple-block-tags branch from 24ae907 to 4200cb7 Compare October 5, 2025 18:00
@LilyFirefly
Test render error in custom block tag content
3ecf250
@LilyFirefly
Store custom block content in target var when as keyword used
5f4ae4f
@LilyFirefly
Make Content::to_py infallible
fb3ddb4 
Django Rusty Templates needs `django.utils.safestring.mark_safe` to
exist and behave correctly in order to work, so raising exceptions
instead of panicking is unnecessary.
@LilyFirefly LilyFirefly marked this pull request as ready for review October 11, 2025 15:32
@LilyFirefly LilyFirefly merged commit 0b2c0a4 into main Oct 11, 2025
18 of 19 checks passed
@LilyFirefly LilyFirefly deleted the custom-simple-block-tags branch October 11, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LilyFirefly LilyFirefly

Labels

enhancement New feature or request refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LilyFirefly