fix(runtime): await in-flight task promises in AgentRuntime.stop() - #280
Merged
David-patrick-chuks-02 merged 2 commits intoSep 6, 2026
Conversation
Fixes Lilly-Protocol#259 - Replaced busy-polling while loop in `drainInFlightTasks()` with event-driven `Promise.race([Promise.allSettled(...), this.sleep(timeoutMs)])`. - Added `inFlightPromises` Map tracking active task execution promises with guaranteed lifecycle cleanup in `finally`. - Added reproduction test suite verifying zero busy-polling sleep cycles and immediate promise unblocking.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
David-patrick-chuks-02
merged commit Sep 6, 2026
38ad7d7
into
Lilly-Protocol:main
0 of 2 checks passed
Contributor
Author
|
Hi @David-patrick-chuks-02! Thank you for the review and merge! USDC Payout Address (BSC BEP-20 / EVM): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259
drainInFlightTasks()with event-drivenPromise.race([Promise.allSettled(...), this.sleep(timeoutMs)]).inFlightPromisesMap tracking active task execution promises with guaranteed lifecycle cleanup infinally.Summary
Describe the change and why it belongs in the runtime foundation.
Checklist