fix(logger): apply secret redaction to InMemoryRuntimeLogger entries (#265) - #274
Merged
David-patrick-chuks-02 merged 2 commits intoSep 6, 2026
Conversation
…illy-Protocol#265) - support optional redactKeys in InMemoryRuntimeLoggerOptions matching ConsoleRuntimeLogger - redact sensitive keys recursively in appendEntry before storing metadata in entries - add unit test coverage for InMemoryRuntimeLogger secret redaction across info/warn/debug/error levels and custom redactKeys
David-patrick-chuks-02
merged commit Sep 6, 2026
dd9507e
into
Lilly-Protocol:main
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #265
This PR ensures sensitive keys (such as
apiKey,password,token,secret,authorization, etc.) are redacted in metadata stored inInMemoryRuntimeLogger, matching the behavior ofConsoleRuntimeLogger.Summary of changes:
redactKeys?: RegExptoInMemoryRuntimeLoggerOptions.this.redactKeyswithoptions.redactKeys ?? DEFAULT_REDACT_KEYS.redactValue(metadata, this.redactKeys)withinInMemoryRuntimeLogger.appendEntrybefore saving metadata tothis.entries.tests/logger/redaction.test.tscovering all log levels (info,warn,debug,error), customredactKeyspattern, and undefined metadata handling.Validation:
npm run verifypassed completely (format, lint, typecheck, tests, coverage).