Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkpoint artifact path prefix to MLflow logger #20538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benglewis
Copy link

@benglewis benglewis commented Jan 8, 2025

Add a new checkpoint_artifact_path_prefix parameter to the MLflow logger.

  • Modify src/lightning/pytorch/loggers/mlflow.py to include the new parameter in the MLFlowLogger class constructor and use it in the after_save_checkpoint method.
  • Update the documentation in docs/source-pytorch/visualize/loggers.rst to include the new checkpoint_artifact_path_prefix parameter.
  • Add a new test in tests/tests_pytorch/loggers/test_mlflow.py to verify the functionality of the checkpoint_artifact_path_prefix parameter and ensure it is used in the artifact path.

For more details, open the Copilot Workspace session.


📚 Documentation preview 📚: https://pytorch-lightning--20538.org.readthedocs.build/en/20538/

Add a new `checkpoint_artifact_path_prefix` parameter to the MLflow logger.

* Modify `src/lightning/pytorch/loggers/mlflow.py` to include the new parameter in the `MLFlowLogger` class constructor and use it in the `after_save_checkpoint` method.
* Update the documentation in `docs/source-pytorch/visualize/loggers.rst` to include the new `checkpoint_artifact_path_prefix` parameter.
* Add a new test in `tests/tests_pytorch/loggers/test_mlflow.py` to verify the functionality of the `checkpoint_artifact_path_prefix` parameter and ensure it is used in the artifact path.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Lightning-AI/pytorch-lightning?shareId=XXXX-XXXX-XXXX-XXXX).
@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant