Skip to content

Support for MPS device mixed-precision #20531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −1
Draft

Support for MPS device mixed-precision #20531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92b13a8
Support for MPS device for mixed-precision
laclouis5 Jan 6, 2025
44f2b03
Changelog
laclouis5 Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lightning/pytorch/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

## [Unreleased]

- Added support for MPS mixed-precision autocast ([#20531](https://github.com/Lightning-AI/pytorch-lightning/pull/20531))

## [2.5.0] - 2024-12-19

### Added
2 changes: 1 addition & 1 deletion src/lightning/pytorch/trainer/connectors/accelerator_connector.py
View file
Original file line number Diff line number Diff line change
@@ -520,7 +520,7 @@ def _check_and_init_precision(self) -> Precision:
rank_zero_info(
f"Using {'16bit' if self._precision_flag == '16-mixed' else 'bfloat16'} Automatic Mixed Precision (AMP)"
)
device = "cpu" if self._accelerator_flag == "cpu" else "cuda"
device = "cpu" if self._accelerator_flag == "cpu" else "mps" if self._accelerator_flag == "mps" else "cuda"
return MixedPrecision(self._precision_flag, device) # type: ignore[arg-type]

raise RuntimeError("No precision set")
Loading