bump: testing with future torch 2.6 #20509

Borda · 2024-12-19T17:17:40Z

What does this PR do?

early visibility for potential breaking changes with next PT release

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20509.org.readthedocs.build/en/20509/

github-actions · 2024-12-19T17:18:10Z

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-14, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-14, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (macOS-14, lightning, 3.11, 2.3)	success	✅
pl-cpu (macOS-14, lightning, 3.12.7, 2.4.1)	success	✅
pl-cpu (macOS-14, lightning, 3.12.7, 2.5.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3)	success	✅
pl-cpu (ubuntu-22.04, lightning, 3.12.7, 2.4.1)	success	✅
pl-cpu (ubuntu-22.04, lightning, 3.12.7, 2.5.1)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (windows-2022, lightning, 3.11, 2.3)	success	✅
pl-cpu (windows-2022, lightning, 3.12.7, 2.4.1)	success	✅
pl-cpu (windows-2022, lightning, 3.12.7, 2.5.1)	success	✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1)	success	✅
pl-cpu (macOS-14, pytorch, 3.12.7, 2.5.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.12.7, 2.5.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.12.7, 2.5.1)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, requirements/pytorch/base.txt, tests/tests_pytorch/conftest.py, tests/tests_pytorch/models/test_onnx.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to .azure/gpu-tests-pytorch.yml, requirements/pytorch/base.txt, tests/tests_pytorch/conftest.py, tests/tests_pytorch/models/test_onnx.py, tests/run_standalone_tests.sh, requirements/fabric/base.txt.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/base.txt.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to .github/workflows/docs-build.yml, requirements/fabric/base.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to .github/workflows/docs-build.yml, requirements/pytorch/base.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.10, 2.1.2, 12.1.1)	success	✅
build-cuda (3.11, 2.2.2, 12.1.1)	success	✅
build-cuda (3.11, 2.3.1, 12.1.1)	success	✅
build-cuda (3.11, 2.4.1, 12.1.1)	success	✅
build-cuda (3.12, 2.5.1, 12.1.1)	success	✅
build-pl (3.10, 2.1, 12.1.1)	success	✅
build-pl (3.11, 2.2, 12.1.1)	success	✅
build-pl (3.11, 2.3, 12.1.1)	success	✅
build-pl (3.11, 2.4, 12.1.1)	success	✅
build-pl (3.12, 2.5, 12.1.1, true)	success	✅

These checks are required after the changes to .github/workflows/docker-build.yml, dockers/base-cuda/Dockerfile, requirements/pytorch/base.txt, requirements/fabric/base.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-14, lightning, 3.9, 2.1, oldest)	success	✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1)	success	✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2.2)	success	✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3)	success	✅
fabric-cpu (macOS-14, lightning, 3.12.7, 2.4.1)	success	✅
fabric-cpu (macOS-14, lightning, 3.12.7, 2.5.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3)	success	✅
fabric-cpu (ubuntu-22.04, lightning, 3.12.7, 2.4.1)	success	✅
fabric-cpu (ubuntu-22.04, lightning, 3.12.7, 2.5.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2.2)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3)	success	✅
fabric-cpu (windows-2022, lightning, 3.12.7, 2.4.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.12.7, 2.5.1)	success	✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1)	success	✅
fabric-cpu (macOS-14, fabric, 3.12.7, 2.5.1)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.12.7, 2.5.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.12.7, 2.5.1)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, .github/workflows/ci-tests-fabric.yml.

🔴 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	failure	❌

These checks are required after the changes to .azure/gpu-tests-fabric.yml, requirements/fabric/base.txt, tests/run_standalone_tests.sh.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/base.txt.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, fabric, 3.9)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.9)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.9)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.9)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-14, fabric, 3.9)	success	✅
install-pkg (macOS-14, fabric, 3.11)	success	✅
install-pkg (macOS-14, pytorch, 3.9)	success	✅
install-pkg (macOS-14, pytorch, 3.11)	success	✅
install-pkg (macOS-14, lightning, 3.9)	success	✅
install-pkg (macOS-14, lightning, 3.11)	success	✅
install-pkg (macOS-14, notset, 3.9)	success	✅
install-pkg (macOS-14, notset, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.9)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.9)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.9)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.9)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/base.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

codecov · 2024-12-19T17:27:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87%. Comparing base (8c2d263) to head (7024590).

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #20509    +/-   ##
========================================
- Coverage      88%      87%    -1%     
========================================
  Files         267      267            
  Lines       23380    23380            
========================================
- Hits        20481    20260   -221     
- Misses       2899     3120   +221

for more information, see https://pre-commit.ci

…tning into ci/bump-pt-2.6

for more information, see https://pre-commit.ci

…tning into ci/bump-pt-2.6

Borda · 2025-01-08T09:47:09Z

seems like bitsandbytes is yet compatible with 2.6

Traceback (most recent call last):
  File "/__w/12/s/requirements/pytorch/check-avail-extras.py", line 10, in <module>
    import bitsandbytes  # noqa: F401
    ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/dist-packages/bitsandbytes/__init__.py", line 15, in <module>
    from .nn import modules
  File "/usr/local/lib/python3.12/dist-packages/bitsandbytes/nn/__init__.py", line 21, in <module>
    from .triton_based_modules import (
  File "/usr/local/lib/python3.12/dist-packages/bitsandbytes/nn/triton_based_modules.py", line 7, in <module>
    from bitsandbytes.triton.int8_matmul_mixed_dequantize import (
  File "/usr/local/lib/python3.12/dist-packages/bitsandbytes/triton/int8_matmul_mixed_dequantize.py", line 12, in <module>
    from triton.ops.matmul_perf_model import early_config_prune, estimate_matmul_time
ModuleNotFoundError: No module named 'triton.ops'

ref: triton-lang/triton#4156 and triton-lang/triton#4236

Borda · 2025-01-09T04:14:20Z

the Fabric "future" failing tests seems to be the same as sometimes for the latest too
https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=223732&view=logs&jobId=c3dc7b52-a90d-58b6-87cc-202b011e273d&j=2840892e-91ab-5245-da62-77ec9923516a&t=84a5b62b-79e0-5474-e104-3e8f01a831f3

asahni04 · 2025-01-09T05:24:16Z

any solution? facing same issue with triton.ops @Borda

bump: testing with future torch 2.6

2bdc588

Borda requested review from lantiga, tchaton, justusschock and ethanwharris as code owners December 19, 2024 17:17

github-actions bot added ci Continuous Integration dockers labels Dec 19, 2024

bump typing-extensions

89153f0

github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Dec 19, 2024

lantiga and others added 7 commits January 6, 2025 11:21

Merge branch 'master' into ci/bump-pt-2.6

b490968

Merge branch 'master' into ci/bump-pt-2.6

6e1f1ba

Merge branch 'master' into ci/bump-pt-2.6

daacd5d

TORCHINDUCTOR_CACHE_DIR

bc3cbd9

[pre-commit.ci] auto fixes from pre-commit.com hooks

6cfa48c

for more information, see https://pre-commit.ci

--extra-index-url=https://download.pytorch.org/whl/cpu/

0e1d047

onnx.log max_torch="2.6.0"

6946f47

github-actions bot added the docs Documentation related label Jan 7, 2025

Borda and others added 9 commits January 7, 2025 16:58

Merge branch 'master' into ci/bump-pt-2.6

6ac85c1

todo

7530f57

Merge branch 'ci/bump-pt-2.6' of https://github.com/Lightning-AI/ligh…

cb73790

…tning into ci/bump-pt-2.6

docker

26a8864

gpu

e52f392

gpu

e7d800f

check

9fb71dc

[pre-commit.ci] auto fixes from pre-commit.com hooks

daa0920

for more information, see https://pre-commit.ci

gpu

6c26f48

Merge branch 'ci/bump-pt-2.6' of https://github.com/Lightning-AI/ligh…

2d8eb16

…tning into ci/bump-pt-2.6

Borda force-pushed the ci/bump-pt-2.6 branch from 440ce70 to 2d8eb16 Compare January 8, 2025 09:52

This comment was marked as off-topic.

Sign in to view

Borda mentioned this pull request Jan 8, 2025

test: flaky terminated with signal SIGABRT #20537

Open

7 tasks

Borda added 6 commits January 8, 2025 20:01

bitsandbytes

3a06681

bitsandbytes

d31f23c

set -e

97cf6ed

fix

5e9009b

future

165d38a

batch

7024590

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump: testing with future torch 2.6 #20509

bump: testing with future torch 2.6 #20509

Borda commented Dec 19, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

Borda commented Jan 8, 2025 •

edited

Loading

This comment was marked as off-topic.

Borda commented Jan 9, 2025

asahni04 commented Jan 9, 2025

bump: testing with future torch 2.6 #20509

Are you sure you want to change the base?

bump: testing with future torch 2.6 #20509

Conversation

Borda commented Dec 19, 2024 • edited by github-actions bot Loading

What does this PR do?

PR review

github-actions bot commented Dec 19, 2024 • edited Loading

⛈️ Required checks status: Has failure 🔴

Groups summary

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

Borda commented Jan 8, 2025 • edited Loading

This comment was marked as off-topic.

Borda commented Jan 9, 2025

asahni04 commented Jan 9, 2025

Borda commented Dec 19, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

Borda commented Jan 8, 2025 •

edited

Loading