Patch Release 2.2.2 #19757

awaelchli · 2024-04-10T18:13:59Z

What does this PR do?

Requires also #19755

cc @Borda @carmocca @justusschock @awaelchli

…mplate/ui (#19319) Bump vite in /src/lightning/app/cli/react-ui-template/ui Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 2.9.16 to 2.9.17. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v2.9.17/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v2.9.17/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Co-authored-by: Dimitri <[email protected]> Co-authored-by: awaelchli <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>

Co-authored-by: Ankit Gola <[email protected]>

…/react-ui-template/ui (#19635) Bump follow-redirects in /src/lightning/app/cli/react-ui-template/ui Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Feat(plugins): adding KeepMachinesAfterStop flag propagation

…efore assertion (#19668) Co-authored-by: Felix Hirwa Nshuti <[email protected]>

Co-authored-by: Jirka Borovec <[email protected]>

Bumps [Lightning-AI/utilities](https://github.com/lightning-ai/utilities) from 0.10.1 to 0.11.0. - [Release notes](https://github.com/lightning-ai/utilities/releases) - [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md) - [Commits](Lightning-AI/utilities@v0.10.1...v0.11.0) --- updated-dependencies: - dependency-name: Lightning-AI/utilities dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Carlos Mocholi <[email protected]>

codecov · 2024-04-10T18:30:43Z

Codecov Report

Merging #19757 (717366a) into release/stable (093fac1) will increase coverage by 0%.
The diff coverage is 54%.

Additional details and impacted files

@@                Coverage Diff                @@
##           release/stable   #19757     +/-   ##
=================================================
  Coverage              83%      84%             
=================================================
  Files                 452      425     -27     
  Lines               38116    34953   -3163     
=================================================
- Hits                31725    29194   -2531     
+ Misses               6391     5759    -632

tchaton · 2024-04-10T18:45:04Z

@awaelchli Can we include this one: #19523. Otherwise, litdata won't be used.

gitguardian · 2024-04-10T18:48:59Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
5685611	Triggered	Generic High Entropy Secret	`e56cf9e`	tests/tests_data/streaming/test_resolver.py	View secret
5685611	Triggered	Generic High Entropy Secret	`e56cf9e`	tests/tests_data/streaming/test_resolver.py	View secret
5685611	Triggered	Generic High Entropy Secret	`e56cf9e`	tests/tests_data/streaming/test_resolver.py	View secret
5685611	Triggered	Generic High Entropy Secret	`e56cf9e`	tests/tests_data/streaming/test_resolver.py	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]>

…#19755)

dependabot bot and others added 19 commits April 10, 2024 18:36

ci: pin pytest for package doctests (#19567)

30ead57

docs: switch NGC link to Nemo (#19568)

b0565ab

bump lightning-utilities from <0.10 to <0.11 (#19586)

e2d74aa

gh: update links in GitHub templates (#19592)

c06959d

Skip failing tests due to dependencies (#19621)

e81d32e

Sharded state dicts save correctly when save_weights_only=True (#19524

3c7181a

) Co-authored-by: Dimitri <[email protected]> Co-authored-by: awaelchli <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>

Fixes incorrect strategy init with HPUAccelerator (#19615)

f2afa60

Co-authored-by: Ankit Gola <[email protected]>

Fix torch.compile patching when applied as decorator (#19627)

113350c

ci/docs: allow failing linkcheck|doctest for dispatch run (#19634)

d3009a7

ci: fix ci-check-md-links args (#19636)

9fd9cf5

Unblock CI from failing CLI test (#19656)

e52e77e

Feat(plugins): adding KeepMachinesAfterStop flag propagation (#19660)

191606a

* Feat(plugins): adding KeepMachinesAfterStop flag propagation

test: move the pretrained model to the same device as current model b…

007b7aa

…efore assertion (#19668) Co-authored-by: Felix Hirwa Nshuti <[email protected]>

Re-enable LightningCLI test disabled due to bug in jsonargparse (#19683)

c4ee62d

ci: bump torch to 2.2.1 (#19687)

6b60e7e

Co-authored-by: Jirka Borovec <[email protected]>

Fix monkeypatching of _FabricModule methods (#19705)

f838ac5

Co-authored-by: Carlos Mocholi <[email protected]>

awaelchli requested review from tchaton, lantiga, ethanwharris, carmocca, justusschock, Borda and williamFalcon as code owners April 10, 2024 18:14

awaelchli added bug Something isn't working release labels Apr 10, 2024

github-actions bot added docs Documentation related ci Continuous Integration labels Apr 10, 2024

awaelchli force-pushed the draft-2-2-2 branch from 02b7705 to 08f8fd5 Compare April 10, 2024 18:21

github-actions bot added docs Documentation related ci Continuous Integration fabric lightning.fabric.Fabric app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file package labels Apr 10, 2024

awaelchli force-pushed the draft-2-2-2 branch from 08f8fd5 to b43555e Compare April 10, 2024 18:46

github-actions bot added the data label Apr 10, 2024

carmocca approved these changes Apr 10, 2024

View reviewed changes

awaelchli force-pushed the draft-2-2-2 branch from d847b04 to 2a5a9e1 Compare April 10, 2024 23:46

migrate Data subpackage (#19523)

e56cf9e

Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]>

awaelchli force-pushed the draft-2-2-2 branch 2 times, most recently from 9eb40be to 4bc7f7e Compare April 11, 2024 00:03

tchaton approved these changes Apr 11, 2024

View reviewed changes

awaelchli changed the title ~~WIP: Patch Release 2.2.2~~ Patch Release 2.2.2 Apr 11, 2024

mergify bot added the ready PRs ready to be merged label Apr 11, 2024

awaelchli added 3 commits April 11, 2024 10:57

Fix initialized weights resetting in Fabric.setup() when using FSDP (…

f4c58e9

…#19755)

Skip tests that cause CLI argparse errors on Python 3.11.9 (#19756)

353727d

Release 2.2.2

717366a

awaelchli force-pushed the draft-2-2-2 branch from b8bb64c to 717366a Compare April 11, 2024 09:58

lantiga approved these changes Apr 11, 2024

View reviewed changes

lantiga merged commit 62e1c6d into release/stable Apr 11, 2024
148 of 150 checks passed

lantiga deleted the draft-2-2-2 branch April 11, 2024 13:09

awaelchli mentioned this pull request Apr 22, 2024

Patch Release 2.2.3 #19800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patch Release 2.2.2 #19757

Patch Release 2.2.2 #19757

awaelchli commented Apr 10, 2024 •

edited by github-actions bot

Loading

codecov bot commented Apr 10, 2024 •

edited

Loading

tchaton commented Apr 10, 2024

gitguardian bot commented Apr 10, 2024 •

edited

Loading

Patch Release 2.2.2 #19757

Patch Release 2.2.2 #19757

Conversation

awaelchli commented Apr 10, 2024 • edited by github-actions bot Loading

What does this PR do?

codecov bot commented Apr 10, 2024 • edited Loading

Codecov Report

tchaton commented Apr 10, 2024

gitguardian bot commented Apr 10, 2024 • edited Loading

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

awaelchli commented Apr 10, 2024 •

edited by github-actions bot

Loading

codecov bot commented Apr 10, 2024 •

edited

Loading

gitguardian bot commented Apr 10, 2024 •

edited

Loading