lint: drop yesqa, covered with RUF100 #19532
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflowThese checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 lightning_app: Tests workflow
These checks are required after the changes to 🟢 lightning_app: Examples
These checks are required after the changes to 🟢 lightning_app: Docs
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
Borda
requested review from
ethanwharris,
carmocca,
justusschock and
williamFalcon
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 5685611 | Triggered | Generic High Entropy Secret | 31ccb77 | tests/tests_app/utilities/test_login.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 9ecd1c0 | tests/tests_app/utilities/test_login.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 21dca9a | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 21dca9a | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 21dca9a | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 21dca9a | tests/tests_data/streaming/test_resolver.py | View secret |
| 7296313 | Triggered | Base64 Basic Authentication | 31ccb77 | tests/tests_app/utilities/test_login.py | View secret |
| 7296313 | Triggered | Base64 Basic Authentication | 31ccb77 | tests/tests_app/utilities/test_login.py | View secret |
| 7296313 | Triggered | Base64 Basic Authentication | 9ecd1c0 | tests/tests_app/utilities/test_login.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
github-actions
bot
added
fabric
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19532 +/- ##
========================================
Coverage 83% 84%
========================================
Files 424 424
Lines 34912 34912
========================================
+ Hits 29061 29212 +151
+ Misses 5851 5700 -151 |
mergify
bot
added
ready
What does this PR do?
https://docs.astral.sh/ruff/rules/unused-noqa/
yesqais quite time consuming, so this is faster and compatibleBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19532.org.readthedocs.build/en/19532/
cc @Borda @carmocca @justusschock @awaelchli