Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BoringFabric in tests #19364

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Refactor BoringFabric in tests #19364

merged 8 commits into from
Jan 30, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jan 29, 2024

What does this PR do?

Removes the BoringFabric pattern. It's only used by the few FSDP end2end tests.
Fixes #17479


📚 Documentation preview 📚: https://pytorch-lightning--19364.org.readthedocs.build/en/19364/

cc @justusschock @awaelchli @carmocca @Borda

@awaelchli awaelchli added refactor fabric lightning.fabric.Fabric tests labels Jan 29, 2024
@awaelchli awaelchli marked this pull request as ready for review January 30, 2024 03:36
@awaelchli awaelchli added this to the 2.2 milestone Jan 30, 2024
Copy link
Contributor

github-actions bot commented Jan 30, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.13, oldest) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success
fabric-cpu (macOS-11, lightning, 3.11, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success
fabric-cpu (windows-2022, lightning, 3.8, 1.13, oldest) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success
fabric-cpu (macOS-12, fabric, 3.11, 2.0) success
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success
fabric-cpu (windows-2022, fabric, 3.11, 2.0) success
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success

These checks are required after the changes to tests/tests_fabric/helpers/datasets.py, tests/tests_fabric/helpers/models.py, tests/tests_fabric/strategies/test_deepspeed_integration.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/strategies/test_xla.py, tests/tests_fabric/strategies/test_xla_fsdp_integration.py, tests/tests_fabric/utilities/test_data.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to tests/tests_fabric/helpers/datasets.py, tests/tests_fabric/helpers/models.py, tests/tests_fabric/strategies/test_deepspeed_integration.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/strategies/test_xla.py, tests/tests_fabric/strategies/test_xla_fsdp_integration.py, tests/tests_fabric/utilities/test_data.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #19364 (3586ae7) into master (6018b07) will decrease coverage by 54%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19364      +/-   ##
==========================================
- Coverage      83%      29%     -54%     
==========================================
  Files         448      440       -8     
  Lines       37878    37724     -154     
==========================================
- Hits        31618    11013   -20605     
- Misses       6260    26711   +20451     

@carmocca carmocca merged commit 01f8531 into master Jan 30, 2024
41 checks passed
@carmocca carmocca deleted the tests/refactor-boring-fabric branch January 30, 2024 22:32
@mergify mergify bot added the ready PRs ready to be merged label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric ready PRs ready to be merged refactor tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Fabric tests that use the old .run() method
3 participants