-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BoringFabric in tests #19364
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 lightning_fabric: CPU workflowThese checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19364 +/- ##
==========================================
- Coverage 83% 29% -54%
==========================================
Files 448 440 -8
Lines 37878 37724 -154
==========================================
- Hits 31618 11013 -20605
- Misses 6260 26711 +20451 |
What does this PR do?
Removes the BoringFabric pattern. It's only used by the few FSDP end2end tests.
Fixes #17479
📚 Documentation preview 📚: https://pytorch-lightning--19364.org.readthedocs.build/en/19364/
cc @justusschock @awaelchli @carmocca @Borda