Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lightning AI multi-node guide #19324

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Update Lightning AI multi-node guide #19324

merged 13 commits into from
Jan 23, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jan 22, 2024

What does this PR do?

Rewrites the docs for the Lightning AI multi-node guide in Fabric. Once this lands, I will update/add the equivalent guide in the Trainer docs as well.

The generated docs can be viewed here:
https://pytorch-lightning--19324.org.readthedocs.build/en/19324/fabric/guide/multi_node/cloud.html

cc @Borda @carmocca @justusschock @awaelchli

@awaelchli awaelchli added docs Documentation related fun Staff contributions outside working hours - to differentiate from the "community" label labels Jan 22, 2024
@awaelchli awaelchli added this to the 2.2 milestone Jan 22, 2024
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jan 22, 2024

This comment was marked as spam.

@awaelchli awaelchli marked this pull request as ready for review January 22, 2024 23:03
Copy link
Contributor

github-actions bot commented Jan 22, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/fundamentals/launch.rst, docs/source-fabric/guide/multi_node/cloud.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested a review from carmocca January 23, 2024 07:14
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's change the title to

Run single or multi-node on Lightning Studios

docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
docs/source-fabric/guide/multi_node/cloud.rst Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jan 23, 2024
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 23, 2024
@awaelchli awaelchli force-pushed the docs/multi-node-guide branch from 9bac77c to 8031dca Compare January 23, 2024 22:22
@awaelchli awaelchli merged commit 1faddcb into master Jan 23, 2024
22 checks passed
@awaelchli awaelchli deleted the docs/multi-node-guide branch January 23, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fabric lightning.fabric.Fabric fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants