Drop support for PyTorch 1.12 #19300
Conversation
github-actions
bot
added
docs
for more information, see https://pre-commit.ci
…htning into feature/drop-torch-1-12
for more information, see https://pre-commit.ci
awaelchli
requested review from
williamFalcon,
lantiga,
carmocca,
justusschock,
tchaton,
Borda and
ethanwharris
as code owners
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🟢 lightning_fabric: CPU workflowThese checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19300 +/- ##
==========================================
- Coverage 83% 54% -29%
==========================================
Files 448 443 -5
Lines 37877 37756 -121
==========================================
- Hits 31375 20292 -11083
- Misses 6502 17464 +10962 |
Co-authored-by: Carlos Mocholí <[email protected]>
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 5685611 | Generic High Entropy Secret | 068dd22 | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Generic High Entropy Secret | 068dd22 | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Generic High Entropy Secret | 068dd22 | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Generic High Entropy Secret | 068dd22 | tests/tests_data/streaming/test_resolver.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…htning into feature/drop-torch-1-12
What does this PR do?
With support for the new PyTorch 2.2 version (#19289), we're removing PyTorch 1.12 support too keep our 4-version support window (1.13, 2.0, 2.1, 2.2).
Previous PR: #18691
📚 Documentation preview 📚: https://pytorch-lightning--19300.org.readthedocs.build/en/19300/
cc @Borda @carmocca @justusschock @awaelchli