Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: build app's docs with RTFD #19147

Merged
merged 3 commits into from
Dec 13, 2023
Merged

ci: build app's docs with RTFD #19147

merged 3 commits into from
Dec 13, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 12, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Addressing #17697 (comment)

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19147.org.readthedocs.build/en/19147/

cc @Borda

@github-actions github-actions bot added the docs Documentation related label Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli added the app (removed) Generic label for Lightning App package label Dec 13, 2023
@awaelchli awaelchli added this to the 2.2 milestone Dec 13, 2023
@mergify mergify bot added the ready PRs ready to be merged label Dec 13, 2023
@Borda Borda merged commit e769e23 into master Dec 13, 2023
24 checks passed
@Borda Borda deleted the ci/rtfd-app branch December 13, 2023 06:37
Borda added a commit that referenced this pull request Dec 19, 2023
@Borda
ci: build app's docs with RTFD (#19147)
4b8ac82 
* ci: build app's docs with RTFD
* set -ex
* .[app]

(cherry picked from commit e769e23)
lantiga pushed a commit that referenced this pull request Dec 20, 2023
@Borda @lantiga
ci: build app's docs with RTFD (#19147)
4d68c1d 
* ci: build app's docs with RTFD
* set -ex
* .[app]

(cherry picked from commit e769e23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @awaelchli @carmocca