-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper support for Remote Stop and Remote Abort with NeptuneLogger #19130
Proper support for Remote Stop and Remote Abort with NeptuneLogger #19130
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19130 +/- ##
==========================================
- Coverage 82% 48% -34%
==========================================
Files 450 442 -8
Lines 38253 38111 -142
==========================================
- Hits 31454 18442 -13012
- Misses 6799 19669 +12870 |
let's update or rebase after #19265 lands 🎏 |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
a818c67
to
28cf077
Compare
@Borda Ready for review 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…y/pytorch-lightning into bugfix/neptune-logger-remote-stop
…19130) Co-authored-by: Rafał Jankowski <[email protected]>
…19130) Co-authored-by: Rafał Jankowski <[email protected]>
What does this PR do?
With Remote Stop and Remote Abort in Neptune UI you're able to stop currently running training this means:
As we're doing a
stop
operation before sending the signal to Lightning the Run may be in an inactivate state when reaching the logger finalization code raising a related exception. This PR prevents this behavior and allows to make graceful shutdown.Fixes neptune-ai/neptune-client#1378
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚 : https://pytorch-lightning--19130.org.readthedocs.build/en/19130/