-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use step
parameter when logging metrics with NeptuneLogger
#19126
Use step
parameter when logging metrics with NeptuneLogger
#19126
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19126 +/- ##
==========================================
- Coverage 83% 49% -34%
==========================================
Files 443 435 -8
Lines 36764 36611 -153
==========================================
- Hits 30617 17977 -12640
- Misses 6147 18634 +12487 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Borda @awaelchli Should I do something with the failing checks? Tests on GPUs look to be empty, docs are failing due to HTTPS/pool/retries errors so probably unrelated as well. |
What does this PR do?
Neptune has a requirement of strictly increasing steps for series. Back then we've been facing some issues regarding the Lightning integration and the order of steps and we had to leave the default behavior. Looks like Lightning is quite safe now with this assumption and some adjustments were made as well like: #11616 so we can get back there.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚 : https://pytorch-lightning--19126.org.readthedocs.build/en/19126/