Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use step parameter when logging metrics with NeptuneLogger #19126

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Dec 8, 2023

What does this PR do?

Neptune has a requirement of strictly increasing steps for series. Back then we've been facing some issues regarding the Lightning integration and the order of steps and we had to leave the default behavior. Looks like Lightning is quite safe now with this assumption and some adjustments were made as well like: #11616 so we can get back there.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚 : https://pytorch-lightning--19126.org.readthedocs.build/en/19126/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #19126 (4ff870e) into master (df869c9) will decrease coverage by 34%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19126      +/-   ##
==========================================
- Coverage      83%      49%     -34%     
==========================================
  Files         443      435       -8     
  Lines       36764    36611     -153     
==========================================
- Hits        30617    17977   -12640     
- Misses       6147    18634   +12487     

@awaelchli awaelchli added logger: neptune community This PR is from the community feature Is an improvement or enhancement labels Dec 9, 2023
@awaelchli awaelchli added this to the 2.2 milestone Dec 9, 2023
Copy link
Contributor

@AleksanderWWW AleksanderWWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the ready PRs ready to be merged label Dec 12, 2023
@Raalsky
Copy link
Contributor Author

Raalsky commented Dec 12, 2023

@Borda @awaelchli Should I do something with the failing checks? Tests on GPUs look to be empty, docs are failing due to HTTPS/pool/retries errors so probably unrelated as well.

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Dec 14, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Dec 14, 2023
@awaelchli awaelchli merged commit 37952fe into Lightning-AI:master Dec 14, 2023
94 checks passed
@Raalsky Raalsky deleted the bugfix/neptune-logger-use-step branch December 14, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement logger: neptune pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants