Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google-github-actions/auth from 1 to 2 #19105

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 4, 2023

Bumps google-github-actions/auth from 1 to 2.

Release notes

Sourced from google-github-actions/auth's releases.

v2

Floating v2 alias

v2.0.0

⚠️ This version requires Node 20 or later on the runner! If you are using GitHub-managed runners, no action is needed. If you are using self-hosted runners, make sure the system version of Node is version 20 or higher.

What's Changed

Full Changelog: google-github-actions/auth@v1...v2.0.0

v1.3.0

What's Changed

Full Changelog: google-github-actions/auth@v1...v1.3.0

v1.2.0

⚠️ This version requires Node 20 or later on the runner! If you are using GitHub-managed runners, no action is needed. If you are using self-hosted runners, make sure the system version of Node is version 20 or higher. Reverted based on community feedback.

What's Changed

New Contributors

Full Changelog: google-github-actions/auth@v1...v1.2.0

v1.1.1

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

📚 Documentation preview 📚: https://pytorch-lightning--19105.org.readthedocs.build/en/19105/

cc @Borda @carmocca

@dependabot dependabot bot requested review from Borda and carmocca as code owners December 4, 2023 01:18
@dependabot dependabot bot added the ci Continuous Integration label Dec 4, 2023
@dependabot dependabot bot requested a review from a team December 4, 2023 01:18
@github-actions github-actions bot added the docs Documentation related label Dec 4, 2023
@Borda Borda changed the title Bump google-github-actions/auth from 1 to 2 Bump google-github-actions/auth from 1 to 2 +tpu Dec 4, 2023
@Borda
Copy link
Member

Borda commented Dec 4, 2023

@carmocca mind checking the failing case or just restart?

@mergify mergify bot added the ready PRs ready to be merged label Dec 4, 2023
@carmocca
Copy link
Contributor

carmocca commented Dec 4, 2023

Seems like the TPU tests are broken right now. I suggest that you undo the change to the tpu test file. It can be updated in the future once they are working again.

@Borda
Copy link
Member

Borda commented Dec 4, 2023

It can be updated in the future once they are working again.

ok, let's wait...
anyway, how is it possible that it is failing when there was no code change?

@carmocca
Copy link
Contributor

carmocca commented Dec 4, 2023

#19022 broke the XRT job (since they used threads too). However, this isn't a big deal because it should be removed before next feature release.

I don't know why the PjRT job is failing though, needs debugging.

@Borda
Copy link
Member

Borda commented Dec 4, 2023

However, this isn't a big deal because it should be removed before next feature release.

so let's remove it on master now?

@carmocca
Copy link
Contributor

carmocca commented Dec 5, 2023

Yes, there will still be the PjRT issue though.

@Borda Borda changed the title Bump google-github-actions/auth from 1 to 2 +tpu Bump google-github-actions/auth from 1 to 2 Dec 12, 2023
@Borda Borda added the run TPU label Dec 12, 2023
@Borda
Copy link
Member

Borda commented Dec 12, 2023

@dependabot rebase

Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 1 to 2.
- [Release notes](https://github.com/google-github-actions/auth/releases)
- [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/auth@v1...v2)

---
updated-dependencies:
- dependency-name: google-github-actions/auth
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot-github_actions-google-github-actions-auth-2 branch from b6f1877 to 152f065 Compare December 12, 2023 19:39
@Borda Borda self-assigned this Dec 12, 2023
@lexierule lexierule merged commit bb44213 into master Dec 13, 2023
18 of 23 checks passed
@lexierule lexierule deleted the dependabot-github_actions-google-github-actions-auth-2 branch December 13, 2023 18:40
Borda pushed a commit that referenced this pull request Dec 19, 2023
Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 1 to 2.
- [Release notes](https://github.com/google-github-actions/auth/releases)
- [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/auth@v1...v2)

---
updated-dependencies:
- dependency-name: google-github-actions/auth
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit bb44213)
lantiga pushed a commit that referenced this pull request Dec 20, 2023
Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 1 to 2.
- [Release notes](https://github.com/google-github-actions/auth/releases)
- [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/auth@v1...v2)

---
updated-dependencies:
- dependency-name: google-github-actions/auth
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit bb44213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related ready PRs ready to be merged run TPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants