Skip to content

Conversation

@kiya00
Copy link
Collaborator

@kiya00 kiya00 commented Nov 19, 2025

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

It's used in GPT-OSS transformer implementation

# File: /sgl-workspace/sglang/python/sglang/srt/distributed/parallel_state.py:562 in all_reduce, code: if input_.is_cpu:
getattr_1 = output_parallel.is_cpu;  getattr_1 = None

Copy link
Collaborator

@mattteochen mattteochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kiya00 !

Copy link
Collaborator

@shino16 shino16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks good to me aside from @kshitij12345's review.

@kiya00
Copy link
Collaborator Author

kiya00 commented Nov 21, 2025

Hi @KaelanDt , could you help review it, it's ready to merge

Copy link
Collaborator

@KaelanDt KaelanDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @kiya00

@kiya00 kiya00 merged commit 9ca2b0d into main Nov 21, 2025
52 checks passed
@kiya00 kiya00 deleted the is_cpu branch November 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants