Add page titles to catalog and Workflow apps#261
Merged
Conversation
Update `application/views/catalog/partials/header.php` Replaced just "LibriVox" as the HTML->head->title with the following: `<page title or 'Browse Catalog'> | LibriVox` Update `application/controllers/catalog/*` Set titles for the following types of pages: * Author pages: `Works by <author name>` * Group pages: `Works in "<group name>"` (including quotes) * Keywords pages: `Works tagged with "<keywords value>"` (including quotes) * Project pages: `<book/project title>` * Reader pages: `Works read by <reader name>` * Reader section details sub-pages: `Section details for <reader name>` All other pages (searching, browsing by language, etc.) will use the default. Update `application/views/catalog/page.php` Use the title that was generated from the Page controller, instead of calling that helper function again from here.
This will save us some boilerplate code in all the Private_Controller sub-classes, when we go to add page titles to HTML->head. I'm leaving Public_Controller alone for now, since it has fewer sub-classes.
Adds page titles to the rest of `application/controllers/`. As with the catalog, each will have " | LibriVox" tacked on the end. The goal was to have each title match the link that took you to the page... with a few exceptions. * Admin pages are 'X Manager', rather than 'Edit X' or 'Manage X'. * Controllers that work with specific items (projects, authors, etc.) should show the name of the item they're currently working with, if any (e.g., `The Betrothal | Section Compiler | LibriVox`) * 'Uploader' and 'Project Template Generator' are referred to by those names.
redrun45
commented
Jun 1, 2025
Comment on lines
-54
to
+63
| if ($project_translators) $results_to_cast = array_merge($results_to_cast, $project_translators); | ||
| if ($project_translators) $results_to_cast = array_merge($results_to_cast, $project_translators); |
Collaborator
Author
There was a problem hiding this comment.
White-space fix! Nothing to see here. 😉
Member
|
I don't want to make perfect the enemy of good enough, but this is the kind of thing that can easily have its own tests, even with our currently wonky test DB setup. Maybe in a follow up patch? :) |
notartom
approved these changes
Jun 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dynamic HTML -> head -> title elements to all pages. No more tabs that are just called 'LibriVox'! 😉