Skip to content

FUP to PR#231 - keywords search dropdown for advanced search#256

Merged
redrun45 merged 1 commit into
LibriVox:masterfrom
notartom:fup-231
May 14, 2025
Merged

FUP to PR#231 - keywords search dropdown for advanced search#256
redrun45 merged 1 commit into
LibriVox:masterfrom
notartom:fup-231

Conversation

@notartom

Copy link
Copy Markdown
Member
  • Remove migration and rely on cron
  • Remove APCU as it's a key-value cache, and doesn't make much sense to use for a single JSON blob

* Remove migration and rely on cron
* Remove APCU as it's a key-value cache, and doesn't make much sense
  to use for a single JSON blob
@notartom

Copy link
Copy Markdown
Member Author

@redrun45 I actually need your approval on this - the approval configuration in GitHub is preventing me from approving my own PR - which is probably a good thing at this point? :)

@redrun45

Copy link
Copy Markdown
Collaborator

@redrun45 I actually need your approval on this - the approval configuration in GitHub is preventing me from approving my own PR - which is probably a good thing at this point? :)

@notartom - Sounds good! I'll get this one applied and do the basic tests this evening, before I give it the OK.

Also this evening, I'll be sending you another small PR, very similar to #247. We'll be replacing the 'archive.org/download/<...>' URLs (which Internet Archive themselves don't seem to use anymore, so not all of their servers support it) with the equivalent '/compress/<...>' links that we see in their web UI.

@redrun45 redrun45 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basic functionality all confirmed, when based on current master. After one run of the cron job, all the keywords function as links.

We'll want to add the cache folder to .gitignore, but I'll send that in with my PR fixing URLs.
👍

@redrun45 redrun45 merged commit 747ea07 into LibriVox:master May 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants