FUP to PR#231 - keywords search dropdown for advanced search#256
Conversation
notartom
commented
May 13, 2025
- Remove migration and rely on cron
- Remove APCU as it's a key-value cache, and doesn't make much sense to use for a single JSON blob
* Remove migration and rely on cron * Remove APCU as it's a key-value cache, and doesn't make much sense to use for a single JSON blob
|
@redrun45 I actually need your approval on this - the approval configuration in GitHub is preventing me from approving my own PR - which is probably a good thing at this point? :) |
@notartom - Sounds good! I'll get this one applied and do the basic tests this evening, before I give it the OK. Also this evening, I'll be sending you another small PR, very similar to #247. We'll be replacing the 'archive.org/download/<...>' URLs (which Internet Archive themselves don't seem to use anymore, so not all of their servers support it) with the equivalent '/compress/<...>' links that we see in their web UI. |
redrun45
left a comment
There was a problem hiding this comment.
The basic functionality all confirmed, when based on current master. After one run of the cron job, all the keywords function as links.
We'll want to add the cache folder to .gitignore, but I'll send that in with my PR fixing URLs.
👍