Repository navigation
Refuse a weights root that another model's campaign already uses - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
rf100vl-campaignrefuses a--weights-rootthat another model's campaign already uses, and never overwrites another model'sstats.json.Why:
<root>/<dataset>/stats.jsonis not namespaced by model. On 2026-10-31 yolov9t and rfdetr-n ran on one root; the later finisher overwrote the other's stats, two yolov9t files were lost, and the yolov9t report printedrecipe sha ?. No error was raised.claim_weights_root(): writes<root>/.campaign-modelon first use; a different model key is refused with a one-line fix. Roots from before this change are checked against their existingstats.jsonmodel keys.stats.jsonthat belongs to another model.--weights-rootper model.Check: the three new tests in
tests/test_campaign_guards.py.Not verified: not rerun on a GPU box; the change only touches root bookkeeping before training starts and the stats write after it ends.
Opened by an agent.
Code provenance
Original code written for this PR; no third-party code ported, adapted, or introduced; no GPL/AGPL/LGPL/non-commercial/unknown-license material involved.