Repository navigation
Make guggenheim-bilbao.jpg the only sample image - #1034
Merged
Merged
Conversation
SAMPLE_IMAGE now points at libreyolo/assets/guggenheim-bilbao.jpg. parkour.jpg and parkour_result.jpg leave the package assets; a test-only copy lives in tests/data/parkour.jpg for parity and golden tests. Scripts, CLI comment and image-agnostic tests use the Guggenheim image. A unit guard (tests/unit/test_no_parkour_sample.py) and an AGENTS.md rule keep parkour out of user-facing material.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAMPLE_IMAGEpointed atlibreyolo/assets/parkour.jpg, so every script, notebook, doc and agent that wanted a sample image picked it up. The project's showcase image isguggenheim-bilbao.jpg; this makes it the only sample image.Changes
SAMPLE_IMAGEnow points atlibreyolo/assets/guggenheim-bilbao.jpg.parkour.jpgleaves the package;parkour_result.jpgis deleted. A test-only copy lives attests/data/parkour.jpg(exposed asPARKOUR_FIXTUREintests/fixture_images.py) for parity tests whose goldens depend on its exact pixels. Goldens are unchanged.image 1/1 guggenheim-bilbao.jpg: 1536x1194 1 person.tests/unit/test_no_parkour_sample.pyfails if "parkour" reappears inlibreyolo/,docs/(exceptdocs/provenance/),notebooks/,scripts/,skills/,tools/,examples/or the READMEs, or if a parkour file is back inlibreyolo/assets/.AGENTS.mdstates the rule.The website (libreyolo.com) already switched every sample link to the Guggenheim image, so no page breaks when this reaches
release.Tests
Locally with
pytest -n 4: the touched unit tests (158 passed, 13 skipped), the new guard, and the affected e2e tests (CLIP embed, CoreML, PP-YOLOE ONNX, PicoSAM3).Code provenance
Original code written for this PR. No code ported or adapted from other repositories.
The PR appears safe to merge.Summary
The PR makes
guggenheim-bilbao.jpgthe shared sample image.Reviews (1) · Last reviewed commit: "chore: make guggenheim-bilbao.jpg the on..." · Reviewed by Greptile