Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] chore: implement logs #4170

Merged
merged 2 commits into from
Dec 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/psalm.yml
Original file line number Diff line number Diff line change
@@ -31,7 +31,8 @@ jobs:
uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
with:
php-version: ${{ steps.versions.outputs.php-available }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, pdo_sqlite, posix, session, simplexml, sqlite, xmlreader, xmlwriter, zip, zlib
ini-values: disable_functions=""
coverage: none
ini-file: development
env:
3 changes: 3 additions & 0 deletions lib/Service/Install/ConfigureCheckService.php
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
use OCA\Libresign\Handler\JSignPdfHandler;
use OCA\Libresign\Helper\ConfigureCheckHelper;
use OCP\AppFramework\Services\IAppConfig;
use Psr\Log\LoggerInterface;

class ConfigureCheckService {
private string $architecture;
@@ -25,6 +26,7 @@ public function __construct(
private JSignPdfHandler $jSignPdfHandler,
private CertificateEngine $certificateEngine,
private SignSetupService $signSetupService,
private LoggerInterface $logger,
) {
$this->architecture = php_uname('m');
}
@@ -243,6 +245,7 @@ private function getErrorAndTipToResultOfVerify(array $result): array {
];
}
}
$this->logger->error('Invalid hash of binaries files', ['result' => $result]);
return [
'Invalid hash of binaries files.',
'Run occ libresign:install --all',