Updated MuseScore to 4.3.2 so newer mscz files could be supported #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid messages like this: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: xxxx For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
`sudo` does not preserve environment variables, while we need the `LUPDATE_ARGS` environment variable. Of course there are ways around that, but the use of sudo is completely unnecessary here, so let's simply remove it.
…entals Fix musescore#22229: export ornament accidentals to MusicXML
4.3.0 translations ports
Update in-repo translation source files
reg.: enumeration value not handled in switch [-Wswitch]
reg.: will be initialized after [-Wreorder]
reg.: this statement may fall through [-Wimplicit-fallthrough=]
reg.: variable set but not used [-Wunused-but-set-variable]
reg.: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
reg.: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
reg.: type qualifiers ignored on function return type [-Wignored-qualifiers]
reg.: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
Error looks like: /home/runner/work/_temp/55608d39-c27e-4b05-bdb8-6c3a00820a6f.sh: line 43: [: !=: unary operator expected
This way, VST plugins that also use qml won't have access to our internal qml folder
…hythms_crash-430 Fix musescore#21953: Crash on regroup rhythms in some scores (4.3.0)
Fix empty figured-bass in MusicXML export
export swing and straight to MusicXML
…mpler_instance_432 destroy_musesampler_instance_432
[4.3.2] Default custom noteheads to normal on non drumset staves
CarlGao4
force-pushed
the
webmscore
branch
2 times, most recently
from
bf6c684 to
815f2d2
Compare
Author
|
Currently, it still only support |
Author
|
I'm not supporting Node.js 18 in this PR Reason: #10 (comment) |
Member
|
Is this ready to be merged or are more commits needed |
Member
|
I just realized I don't have maintainer permissions on this repository, so I can't merge it |
Author
|
It's ready now, the CI has passed: https://github.com/CarlGao4/webmscore/actions/runs/14575709935 |
Author
Author
|
I'll close this PR and maintain my new repo. Maybe I can upload the project to npmjs using a new name like "webmscore4" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2
close #14
@Xmader