Set original type to images within ImageLoader for OpenRTF support #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Also, OpenRTF dependencies would need to be updated to use a newest version of OpenPDF containing this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
This fix has been made to solve an issue with OpenRTF expecting an original type to be set for an Image to use it for a cell / document.
Related Issue: see LibrePDF/OpenRTF#15
Your real name
Olivier Delierre
Testing details
You would need to clone OpenRTF and use OpenPDF with this patch as a dependency, then, to generate a RTF file with anything but a JPG file.