Skip to content

Revert "ARRISEOS-45892 GC finetuning #2" #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marcin-mielczarczyk-red wants to merge 1 commit into
base: lgi-wpe-2.38-25Q1
Choose a base branch
from
Draft

Revert "ARRISEOS-45892 GC finetuning #2" #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/runtime/VM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ void VM::shrinkFootprintWhenIdle()
{
whenIdle([=, this] () {
sanitizeStackForVM(*this);
deleteAllCode(PreventCollectionAndDeleteAllCode);
deleteAllCode(DeleteAllCodeIfNotCollecting);
heap.collectNow(Synchronousness::Sync, CollectionScope::Full);
// FIXME: Consider stopping various automatic threads here.
// https://bugs.webkit.org/show_bug.cgi?id=185447
Expand Down
2 changes: 1 addition & 1 deletion Source/WTF/wtf/MemoryPressureHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ static const double s_conservativeThresholdFraction = 0.8;
static const double s_strictThresholdFraction = 0.9;
#endif
static const std::optional<double> s_killThresholdFraction;
static const Seconds s_pollInterval = 5_s;
static const Seconds s_pollInterval = 30_s;

// This file contains the amount of video memory used, and will be filled by some other
// platform component. It's a text file containing an unsigned integer value.
Expand Down
4 changes: 0 additions & 4 deletions Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,6 @@ bool InjectedBundle::isProcessingUserGesture()
void InjectedBundle::garbageCollectJavaScriptObjects()
{
GCController::singleton().garbageCollectNow();
WTF::releaseFastMallocFreeMemory();

JSLockHolder lock(commonVM());
commonVM().shrinkFootprintWhenIdle();
}

void InjectedBundle::garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging(bool waitUntilDone)
Expand Down