-
Notifications
You must be signed in to change notification settings - Fork 27
APOSMM accepts an initial sample, via ingest #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlnav
wants to merge
11
commits into
experimental/jlnav_plus_shuds_asktell
Choose a base branch
from
asktell/nov_aposmm_refactor
base: experimental/jlnav_plus_shuds_asktell
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
APOSMM accepts an initial sample, via ingest #1616
jlnav
wants to merge
11
commits into
experimental/jlnav_plus_shuds_asktell
from
asktell/nov_aposmm_refactor
+402
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an attempt to make the arg perform an extra receive so the user can pass in those values. add the boilerplate for an extra test
…an happen as expected
…ust pass the data as-is into the gen_f
…ition where aposmm receives until enough have been received, then local_H is updated with the method used when libE has returned points. Then fix something_sent condition. Also the update_local_H_after_receiving resizes local_H in this initialization routine. Then in generators.py, ensure additionally that Work can ingest points without sim_id needing to be in results. Assume that an np.arange is good enough
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental/jlnav_plus_shuds_asktell #1616 +/- ##
==========================================================================
+ Coverage 78.73% 93.70% +14.97%
==========================================================================
Files 79 79
Lines 7993 8051 +58
Branches 1196 1213 +17
==========================================================================
+ Hits 6293 7544 +1251
+ Misses 1481 324 -1157
+ Partials 219 183 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0dfae0a to
5dc5155
Compare
…, primarily displaying a series of warnings about the characteristics of vocs
…interacting with the aposmm class may fail. add supported globus_compute_sdk version to dev env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on concepts and keyword argument names from shuds' #1615 .
do_not_produce_sample_pointsfield, specifying to APOSMM that user will ingest first.sim_idshouldn't be necessary.initial_sample_sizepoints received. Then updatelocal_Has though "actual" evaluations were received.ingestfirst on an interfacer generator starts the background process.