Skip to content

Conversation

@jlnav
Copy link
Member

@jlnav jlnav commented Nov 7, 2025

Based on concepts and keyword argument names from shuds' #1615 .

  1. New do_not_produce_sample_points field, specifying to APOSMM that user will ingest first.
  2. Fix various circumstances and conditions where specifying sim_id shouldn't be necessary.
  3. Within gen_f: if new field is specified, keep receiving until initial_sample_size points received. Then update local_H as though "actual" evaluations were received.
  4. Calling ingest first on an interfacer generator starts the background process.
  5. Unit test for the above
  6. [11/14] Try to account for a handful of error conditions

jlnav added 9 commits November 6, 2025 10:34
… an attempt to make the arg perform an extra receive so the user can pass in those values. add the boilerplate for an extra test
…ition where aposmm receives until enough have been received, then local_H is updated with the method used when libE has returned points. Then fix something_sent condition. Also the update_local_H_after_receiving resizes local_H in this initialization routine. Then in generators.py, ensure additionally that Work can ingest points without sim_id needing to be in results. Assume that an np.arange is good enough
@jlnav jlnav marked this pull request as ready for review November 13, 2025 16:24
@jlnav jlnav requested review from jmlarson1 and shuds13 November 13, 2025 16:24
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 84.37500% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.70%. Comparing base (41a4cbc) to head (b7a79c3).

Files with missing lines Patch % Lines
libensemble/gen_funcs/persistent_aposmm.py 58.82% 10 Missing and 4 partials ⚠️
libensemble/generators.py 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           experimental/jlnav_plus_shuds_asktell    #1616       +/-   ##
==========================================================================
+ Coverage                                  78.73%   93.70%   +14.97%     
==========================================================================
  Files                                         79       79               
  Lines                                       7993     8051       +58     
  Branches                                    1196     1213       +17     
==========================================================================
+ Hits                                        6293     7544     +1251     
+ Misses                                      1481      324     -1157     
+ Partials                                     219      183       -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…, primarily displaying a series of warnings about the characteristics of vocs
…interacting with the aposmm class may fail. add supported globus_compute_sdk version to dev env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants