Skip to content

libvncclient: add hooks for custom socket I/O #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobydox
Copy link
Contributor

@tobydox tobydox commented Jul 19, 2021

This allows using libvncclient on any kind of custom transport, e.g. for TLS tunneling via a special TLS socket implementation. May be the function pointer / hook names can be improved to better reflect the actual purpose.

@bk138
Copy link
Member

bk138 commented Jul 19, 2021

Am currently on vacation, can review end of July - how does this relate to / replace #234?

@tobydox
Copy link
Contributor Author

tobydox commented Jul 20, 2021

It's related partially only since it proposes changes to the RFB protocol for negotiating TLS. This PR is much more generic and not even TLS related, TLS is just a use case.

@bk138
Copy link
Member

bk138 commented Apr 28, 2022

IIRC this is about generic tunneling, an example of how to make use of this would be super helpful.

@bk138 bk138 self-assigned this May 26, 2022
@tobydox tobydox force-pushed the custom-socket-io branch 2 times, most recently from c0796c6 to 72c2e71 Compare February 22, 2023 12:23
@GregorWaltzR
Copy link

I need a connect hook to negotiate with a proxy server before handing the connection to libvncclient. I rolled my own before seeing this one. The ConnectToRFBServer hook proposed here would meet my need.

@bk138 bk138 removed their assignment Aug 5, 2023
@bk138 bk138 mentioned this pull request Nov 11, 2023
3 tasks
@bk138 bk138 mentioned this pull request Nov 3, 2024
This allows using libvncclient on any kind of custom transport, e.g.
for TLS tunneling via a special TLS socket implementation.
@tobydox tobydox force-pushed the custom-socket-io branch from 72c2e71 to 0ee9b2a Compare May 7, 2025 05:46
@tobydox
Copy link
Contributor Author

tobydox commented May 7, 2025

I'm back working on this topic, specifically to make libvncclient usable with a custom Websocket implementation. @bk138: you mentioned an example would be helpful. Should I add a file in client/examples using the new callbacks? Alternatively I could extend the Qt example to work with QWebSockets (which would be my use case as well).

@bk138
Copy link
Member

bk138 commented May 16, 2025

Hi Toby,
An example would be nice, yes. I am currently rather limited on time, sorry for the delay in answering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants