Open
Conversation
Owner
|
@cheton , did you tested it? I believe on that loop errors setup isn't made yet since |
Author
|
Sorry for that I did make a mistake, the How about using an error-first callback for the validate function? this.form.validateAll((err) => {
if (err) {
return;
}
const { name, password } = this.form.getValues();
// Save changes
}); |
Author
|
I made a little change to the code using the error-first callback, this should fix the issue existed in this PR. |
|
I'd love this feature to validate the whole form before submitting. I have to do I manually with refs to all inputs inside a form and it's awful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasErrors()method to return a boolean valuevalidate()andvalidateAll()will return a boolean value after validation.This PR enables support for the following use case.