-
Notifications
You must be signed in to change notification settings - Fork 142
Multi-group support + dependency fixes #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Could verification checks be an option to be enabled for secondary groups as well? |
|
Did some minimal testing, but could use someone with the whole proper Bloxlink + multi-group setup to test more thoroughly. Thanks for the feedback. |
|
This might be very specific, but could a bypass for verification checks be created for role ids as well? |
|
You should add permissions for specific groups. Doing some multi-group testing. |
|
Verification Checks for seconary groups, making sure they cant accept / exile higher ranks or accepting if theyre not in the group at all |
|
Comman to see all groupbans |
Started a draft for additional permissions per secondary group. -- Untested, nor completed. |
|
logs showing what secondary group they got accepted into and if theyre being ranked what group it is |
Update: Majority of the draft is completed with a re-write of multi-group. I have 2 issues to fix and testing to start before I submit a PR. |
Only needs to be added to join requests. Already a feature for ranking. |
|
@vq9o When your PR is ready, you can submit it to the |
This pull request adds support for performing basic ranking actions on configured secondary groups. It also fixes issues with the
gotdependency saying it is not installed, even though it's Bloxy importing it.Testing status
[M]- Multi-group actions[M]- Multi-group logging[P]- Multi-group verification checks[F]- Dependency bug fixP = partially tested; M = mostly tested; F = fully tested.
Feedback needed
Broadly: does this do everything you would expect from multi-group functionality?
Specifically (non-exhaustive):