Skip to content

Conversation

@yogurtsyum
Copy link
Collaborator

@yogurtsyum yogurtsyum commented Mar 14, 2024

This pull request adds support for performing basic ranking actions on configured secondary groups. It also fixes issues with the got dependency saying it is not installed, even though it's Bloxy importing it.

Testing status

[M] - Multi-group actions
[M] - Multi-group logging
[P] - Multi-group verification checks
[F] - Dependency bug fix

P = partially tested; M = mostly tested; F = fully tested.

Feedback needed

Broadly: does this do everything you would expect from multi-group functionality?

Specifically (non-exhaustive):

  • Verification checks are currently ran on the main group, even if the action is being applied to a secondary group. Is this what you would expect?

@HyronHydel
Copy link

HyronHydel commented Mar 14, 2024

Could verification checks be an option to be enabled for secondary groups as well?

@yogurtsyum
Copy link
Collaborator Author

yogurtsyum commented Mar 14, 2024

Did some minimal testing, but could use someone with the whole proper Bloxlink + multi-group setup to test more thoroughly. Thanks for the feedback.

@HyronHydel
Copy link

This might be very specific, but could a bypass for verification checks be created for role ids as well?

@vq9o
Copy link

vq9o commented Mar 24, 2024

You should add permissions for specific groups. Doing some multi-group testing.

@Jxkeyy
Copy link

Jxkeyy commented Mar 24, 2024

Verification Checks for seconary groups, making sure they cant accept / exile higher ranks or accepting if theyre not in the group at all

@Jxkeyy
Copy link

Jxkeyy commented Mar 24, 2024

Comman to see all groupbans

@vq9o
Copy link

vq9o commented Mar 24, 2024

You should add permissions for specific groups. Doing some multi-group testing.

Started a draft for additional permissions per secondary group. -- Untested, nor completed.
multigroup...vq9o:qbot:multigroup

@Jxkeyy
Copy link

Jxkeyy commented Mar 25, 2024

logs showing what secondary group they got accepted into and if theyre being ranked what group it is

@vq9o
Copy link

vq9o commented Mar 25, 2024

You should add permissions for specific groups. Doing some multi-group testing.

Started a draft for additional permissions per secondary group. -- Untested, nor completed. multigroup...vq9o:qbot:multigroup

Update: Majority of the draft is completed with a re-write of multi-group. I have 2 issues to fix and testing to start before I submit a PR.
https://github.com/vq9o/qbot/blob/multigroup/PR_INFO.md

@yogurtsyum
Copy link
Collaborator Author

yogurtsyum commented Mar 25, 2024

logs showing what secondary group they got accepted into and if theyre being ranked what group it is

Only needs to be added to join requests. Already a feature for ranking.

@yogurtsyum
Copy link
Collaborator Author

@vq9o When your PR is ready, you can submit it to the multigroup branch here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants