feat(ui-react/ui-rnative): add Trend component#678
Open
aquelemiguel wants to merge 23 commits intomainfrom
Open
feat(ui-react/ui-rnative): add Trend component#678aquelemiguel wants to merge 23 commits intomainfrom
aquelemiguel wants to merge 23 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zel-kass
approved these changes
May 5, 2026
| control: 'boolean', | ||
| }, | ||
| }, | ||
| }; |
Collaborator
There was a problem hiding this comment.
[low]: Storybook's docs example on how to define a story stipulates :
const meta = {
component: Button,
} satisfies Meta<typeof Button>;
The typing is slightly different, though I don't think this impacts anything at all, I usually declare them following the docs format, should we align on one way or another, or totally skip ?
Contributor
Author
There was a problem hiding this comment.
i agree, we're widening the type, we infer args better with the satisfies keyword.
entire codebase uses the former though, so i'm all for creating a ticket to settle on a standard
Collaborator
There was a problem hiding this comment.
love it, we're aligned, creating the ticket rn
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Trend indicator component to the React Native UI library, including Storybook documentation, automated tests, sandbox showcasing, and localized accessibility labels.
Changes:
- Introduces
Trendcomponent (positive/negative/neutral variants) with sizing and disabled styling. - Adds Storybook stories + MDX docs and a sandbox block to preview the component.
- Extends i18n resources/locales with Trend accessibility labels and preloads locale resources at i18n init.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/ui-rnative/src/lib/Components/Trend/types.ts | Defines the public TrendProps API for the new component. |
| libs/ui-rnative/src/lib/Components/Trend/Trend.tsx | Implements Trend rendering, formatting, styling, and accessibility labels. |
| libs/ui-rnative/src/lib/Components/Trend/Trend.test.tsx | Adds unit tests for formatting, variants, and accessibility labels. |
| libs/ui-rnative/src/lib/Components/Trend/Trend.stories.tsx | Adds Storybook stories for base/variants/sizes/disabled states. |
| libs/ui-rnative/src/lib/Components/Trend/Trend.mdx | Adds Storybook MDX documentation for Trend usage and behavior. |
| libs/ui-rnative/src/lib/Components/Trend/index.ts | Exposes Trend exports via the component folder barrel. |
| libs/ui-rnative/src/lib/Components/index.ts | Exports Trend from the main components barrel. |
| libs/ui-rnative/src/i18n/locales/zh.json | Adds Chinese Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/tr.json | Adds Turkish Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/th.json | Adds Thai Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/ru.json | Adds Russian Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/pt.json | Adds Portuguese Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/ko.json | Adds Korean Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/ja.json | Adds Japanese Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/fr.json | Adds French Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/es.json | Adds Spanish Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/locales/en.json | Adds English Trend accessibility label strings (used by tests). |
| libs/ui-rnative/src/i18n/locales/de.json | Adds German Trend accessibility label strings. |
| libs/ui-rnative/src/i18n/i18n.ts | Preloads all locale resources into i18next at initialization. |
| apps/app-sandbox-rnative/src/app/blocks/Trends.tsx | Adds a sandbox block to preview Trend across states/sizes. |
| apps/app-sandbox-rnative/src/app/blocks/index.ts | Exports the new Trends sandbox block and reorders block exports. |
| apps/app-sandbox-rnative/src/app/App.tsx | Integrates the Trends sandbox block into the sandbox app UI. |
| .nx/version-plans/version-plan-1777911187465.md | Declares a patch version bump for @ledgerhq/lumen-ui-rnative. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aammami-ledger
approved these changes
May 5, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DLS-670.
Checklist
Sandbox (iOS)