[Dls 680] refactor(BaseInput): Add status and helperText#653
Open
aammami-ledger wants to merge 21 commits intomainfrom
Open
[Dls 680] refactor(BaseInput): Add status and helperText#653aammami-ledger wants to merge 21 commits intomainfrom
status and helperText#653aammami-ledger wants to merge 21 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the shared input feedback API across React and React Native components by replacing errorMessage with helperText plus a status prop for error/success/neutral helper presentation.
Changes:
- Replaced
errorMessageusage withhelperTextand addedstatus(error|success) across BaseInput and input wrappers (Text/Search/Address) in React + React Native. - Updated stories, tests, and Figma connectors to reflect the new helper/status API (including neutral and success examples).
- Added Nx version-plan entries documenting the breaking change and migration steps.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/ui-rnative/src/lib/Components/TextInput/TextInput.tsx | Updates component docs to describe helperText + status. |
| libs/ui-rnative/src/lib/Components/TextInput/TextInput.stories.tsx | Reworks stories to use helper/status; adds success + neutral variants. |
| libs/ui-rnative/src/lib/Components/SearchInput/SearchInput.stories.tsx | Migrates error story to helper/status. |
| libs/ui-rnative/src/lib/Components/BaseInput/types.ts | Introduces BaseInputStatus; replaces errorMessage with helperText + status. |
| libs/ui-rnative/src/lib/Components/BaseInput/BaseInput.tsx | Implements helper rendering + status-driven styling and icons. |
| libs/ui-rnative/src/lib/Components/AddressInput/AddressInput.stories.tsx | Migrates error story to helper/status. |
| libs/ui-react/src/lib/Components/TextInput/TextInput.tsx | Updates component docs to describe helperText + status. |
| libs/ui-react/src/lib/Components/TextInput/TextInput.test.tsx | Updates tests for helper/status; adds neutral + success coverage. |
| libs/ui-react/src/lib/Components/TextInput/TextInput.stories.tsx | Migrates stories to helper/status; adds success + neutral variants. |
| libs/ui-react/src/lib/Components/TextInput/TextInput.figma.tsx | Updates Figma mapping to helperText + status. |
| libs/ui-react/src/lib/Components/Select/types.ts | Extends SelectSearch pick to include helperText + status. |
| libs/ui-react/src/lib/Components/Select/Select.tsx | Plumbs helper/status through SelectSearch -> SearchInput. |
| libs/ui-react/src/lib/Components/SearchInput/SearchInput.tsx | Updates docs to describe helper/status. |
| libs/ui-react/src/lib/Components/SearchInput/SearchInput.test.tsx | Migrates test to helper/status. |
| libs/ui-react/src/lib/Components/SearchInput/SearchInput.stories.tsx | Migrates story + code sample to helper/status. |
| libs/ui-react/src/lib/Components/BaseInput/types.ts | Introduces BaseInputStatus; replaces errorMessage with helperText + status. |
| libs/ui-react/src/lib/Components/BaseInput/BaseInput.tsx | Implements helper/status rendering (icons, aria-describedby, role=alert), adds CVA variants. |
| libs/ui-react/src/lib/Components/AddressInput/AddressInput.tsx | Updates docs to describe helper/status. |
| libs/ui-react/src/lib/Components/AddressInput/AddressInput.test.tsx | Migrates test to helper/status. |
| libs/ui-react/src/lib/Components/AddressInput/AddressInput.stories.tsx | Migrates stories + code samples to helper/status. |
| libs/ui-react/src/lib/Components/AddressInput/AddressInput.figma.tsx | Updates Figma mapping to helperText + status. |
| apps/app-sandbox-rnative/src/app/blocks/TextInputs.tsx | Updates sandbox examples to helper/status; adds a success example. |
| .nx/version-plans/version-plan-1776837602000.md | Documents native package breaking change + migration guide (major). |
| .nx/version-plans/version-plan-1776837601000.md | Documents react package breaking change + migration guide (currently marked patch). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 38 out of 38 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…prop for validation feedback
…ct and React Native inputs
…atus props across components
Co-authored-by: Copilot <[email protected]>
…move unnecessary async/await
…ncing input usability
… and relying on status for accessibility
Co-authored-by: Copilot <[email protected]>
…a-invalid based on error status
Co-authored-by: Copilot <[email protected]>
…nce input feedback
…tyles based on status
…mic status prop and removing focus states
aammami-ledger
force-pushed
the
DLS-680-text-input
branch
from
cb03ac1 to
92d8742
Compare
zel-kass
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Success and neutral states:
Enable combining Label + Placeholder:
Update playground: