Skip to content

Fix ADDRESS_BOOK_ALIAS address page on Nano#1560

Merged
cedelavergne-ledger merged 5 commits into
masterfrom
cev/address_book_feedback
May 20, 2026
Merged

Fix ADDRESS_BOOK_ALIAS address page on Nano#1560
cedelavergne-ledger merged 5 commits into
masterfrom
cev/address_book_feedback

Conversation

@cedelavergne-ledger
Copy link
Copy Markdown
Contributor

@cedelavergne-ledger cedelavergne-ledger commented May 19, 2026

Description

  • ADDRESS_BOOK_ALIAS: Fix title and text on the page
  • Fix Last page strings for Address Book for Nano
  • Adjust Address Book UI wordings for Nano
  • Ensure correct truncation with '...' on Nano
  • Add 'Look At Me' notification in nbgl_useCaseChoiceWithDetails

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Auto cherry-pick in API_LEVEL

If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:

[x] TARGET_API_LEVEL: API_LEVEL_26

This will only create the PR with cherry-picks, ready to be reviewed and merged.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (b7d1089) to head (fb31b19).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1560   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          39       39           
  Lines        4653     4653           
  Branches      584      584           
=======================================
  Hits         4275     4275           
  Misses        266      266           
  Partials      112      112           
Flag Coverage Δ
unittests 91.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cedelavergne-ledger cedelavergne-ledger merged commit 8e2c871 into master May 20, 2026
231 of 234 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/address_book_feedback branch May 20, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants