Remove OS-specific header includes#1514
Open
yrichard-ledger wants to merge 2 commits intomasterfrom
Open
Conversation
yrichard-ledger
force-pushed
the
yri_remove_private_arch_defs
branch
from
bec04d0 to
372c47a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 39 39
Lines 4653 4653
Branches 584 584
=======================================
Hits 4275 4275
Misses 266 266
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrichard-ledger
force-pushed
the
yri_remove_private_arch_defs
branch
2 times, most recently
from
d70b979 to
465fb16
Compare
yrichard-ledger
force-pushed
the
yri_remove_private_arch_defs
branch
from
465fb16 to
3f147a4
Compare
yrichard-ledger
force-pushed
the
yri_remove_private_arch_defs
branch
from
4f7be32 to
f9beecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To cleanup the build system, remove some includes that are only used by the OS and have no place in the app SDK
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it.
Additional comments
Please post additional comments in this section if you have them, otherwise delete it.
Auto cherry-pick in API_LEVEL
If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:
[ ] TARGET_API_LEVEL: API_LEVEL_25
[ ] TARGET_API_LEVEL: API_LEVEL_26
This will only create the PR with cherry-picks, ready to be reviewed and merged.
Remember: