WIP: Use dynamic memory for NBGL objects/containers#1409
Open
nroggeman-ledger wants to merge 1 commit intomasterfrom
Open
WIP: Use dynamic memory for NBGL objects/containers#1409nroggeman-ledger wants to merge 1 commit intomasterfrom
nroggeman-ledger wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1409 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 34 34
Lines 3353 3353
Branches 435 435
=======================================
Hits 3022 3022
Misses 244 244
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nroggeman-ledger
force-pushed
the
use-dynamic-mem-for-nbgl
branch
2 times, most recently
from
c7b7181 to
22d59b1
Compare
| (void) exitCode; | ||
| } | ||
|
|
||
| mem_ctx_t mem_init(void *heap_start, size_t heap_size) |
Contributor
There was a problem hiding this comment.
With those function, I think we cannot fuz the lib_alloc...
I would suggest to rather put them in your nbgl harness
Contributor
Author
There was a problem hiding this comment.
Plus utilisé, et de toute façon cette PR va finir à la poubelle
nroggeman-ledger
force-pushed
the
use-dynamic-mem-for-nbgl
branch
from
22d59b1 to
9b2d230
Compare
nroggeman-ledger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to adapt SDK to NBGL now using real dynamic allocator.
It means that:
nbgl_objPoolStat()Changes include
Breaking changes
Because prototypes of nbgl_obj_pool functions have changed, it is incompatible with API_LEVEL_25 implem