Initialize and check the stack canary at every io_tx/io_rx call#358
Merged
Initialize and check the stack canary at every io_tx/io_rx call#358
Conversation
yogh333
changed the title
There was a problem hiding this comment.
Pull request overview
This pull request adds stack overflow protection to the Ledger device SDK by implementing a canary value mechanism. The canary is placed in memory between the .bss section and the stack (as defined in the linker script), and is checked on every APDU I/O operation through the io_rx and io_tx functions.
Changes:
- Adds a new
canarymodule inseph.rsthat initializes and checks a magic value (0xDEAD0031) stored at theapp_stack_canarylinker symbol - Integrates canary checks into both
io_rxandio_txfunctions, which are the primary I/O entry points used throughout the codebase - Uses volatile operations to prevent compiler optimization and panics if corruption is detected
yogh333
force-pushed
the
stack_canary
branch
from
4fae586 to
b786621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dupplicate of #333 as PR master are now forbidden