Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo SPL send implementation following spec update #109

Closed
wants to merge 1 commit into from
Closed

Redo SPL send implementation following spec update #109

wants to merge 1 commit into from

Conversation

fbeutin-ledger
Copy link

No description provided.

@fbeutin-ledger fbeutin-ledger force-pushed the fbe/revamp_spl_send branch 6 times, most recently from 8378f4d to 9b36f57 Compare January 21, 2025 15:46
@fbeutin-ledger
Copy link
Author

C tests are broken because there is no mock feature
To fix later, too big to implement
Also this architecture split between libsol and src should be thought over

@fbeutin-ledger fbeutin-ledger force-pushed the fbe/revamp_spl_send branch 5 times, most recently from bf9a872 to 26bbe8b Compare January 21, 2025 16:13
@bboilot-ledger bboilot-ledger mentioned this pull request Jan 22, 2025
Closed
bboilot-ledger
bboilot-ledger reviewed Jan 22, 2025
View reviewed changes
Copy link

@bboilot-ledger bboilot-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C tests are broken because there is no mock feature
To fix later, too big to implement
Also this architecture split between libsol and src should be thought over

Yeah, I think the fuzzer might be broken too

@fbeutin-ledger fbeutin-ledger force-pushed the fbe/revamp_spl_send branch 2 times, most recently from 768938d to ba3d749 Compare January 23, 2025 13:24
@fbeutin-ledger
Copy link
Author

#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboilot-ledger bboilot-ledger bboilot-ledger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbeutin-ledger @bboilot-ledger