Skip to content

Issue 732 guard negative lookback days - #849

Merged
Markadrian6399 merged 3 commits into
Ledger-Lenz:mainfrom
Kabukabs:issue-732-guard-negative-lookback-days
Sep 1, 2026
Merged

Issue 732 guard negative lookback days#849
Markadrian6399 merged 3 commits into
Ledger-Lenz:mainfrom
Kabukabs:issue-732-guard-negative-lookback-days

Conversation

@Kabukabs

Copy link
Copy Markdown

Summary

What does this PR change and why?

Type of change

fixes #732
closes #732

  • Bug fix
  • New feature
  • Data/schema change (affects feature columns, data models, Avro schema)
  • Model change (affects training, inference, or evaluation metrics)
  • Infrastructure / CI change
  • Documentation only
  • Security fix

Changelog

### Added / Changed / Fixed / ...
- <your entry here>

Impact assessment

Data / feature schema changes

  • No schema changes
  • New feature columns added (update data/feature_dictionary.md)
  • Feature columns removed or renamed (update feature_schema_hash; note downstream impact)
  • Avro schema evolved (backward-compatible / breaking)

Model changes

  • No model changes
  • Model retrained — include before/after AUC-ROC / F1 in the summary above
  • Inference API changed — update ledgerlens-core if RiskScore shape changed
  • Feature schema hash will change — all consumers need to reload models

Downstream impact

  • ledgerlens-api — REST API response shape may change
  • ledgerlens-dashboard — visualization or SHAP field names may change
  • ledgerlens-contract — on-chain RiskScore struct may change
  • ledgerlens-core — shared types or thresholds may change
  • None

Checklist

  • make test passes locally
  • make lint and make format are clean
  • New/changed behavior has test coverage
  • CHANGELOG.md updated under [Unreleased]
  • If a shared contract changed (RiskScore, asset pair format, feature
    schema), linked issues/PRs in ledgerlens-core and downstream repos

@Markadrian6399
Markadrian6399 merged commit 4f8bc3f into Ledger-Lenz:main Sep 1, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guard against negative --lookback-days in retrain_if_drifted.py

3 participants