Repository navigation
Conversation
added 2 commits
September 4, 2026 00:18
…er a bare 500 The close and converse authors could raise straight through the route: FastAPI answered `Internal Server Error`, the shell rendered "connection lost -- try again" over a server that was up, the sitting stayed live, and every retry paid for one more identical failure. The ceiling fires here as ModelError; a 401 or an overload arrives as the SDK's own class, which `_timed` does not wrap, so the net is broad like the worker's. close: traceback server side (Invariant 10), then the same static `voice` already serves on a refusal, with the village, and the sitting still ends. converse: a nudge that says nothing was sent, so the shell hands her words back; the turn is released so the retry is real. The steer mapper is the second paid call on a converse turn and runs after the reply was authored; its failure now takes no steer instead of throwing the reply away. Seven tests, each watched to fail on the escaping exception or the 500 before the fix. Gate: 1446 passed, 35 skipped.
…teau, one net over the lost-context screen, the label as chrome Three findings from the isolated T2 review at 540f101, each read at the cited span and each fixed behind a test watched to fail first. The static close lied on a plateau. Every stop lands post-Earned-Landing, so a plateau or budget record reaches the close author too, and on an author failure the first fix served "You took a position and reasoned the trade-offs" to a learner who never landed the call. Converged now serves that line, which is then true; anything else serves the close-shaped static that claims no arrival. The lost-context second screen escaped. The net wrapped only the author call; the lost-context branch then ran egress_safe_reply against the lost exp, whose own catch is ModelError-only, so an SDK-class error there was still a bare 500. One net now covers both; nothing is persisted before either, so the nudge stays true. A label attach failure after persist duplicated the turn. The wind-down label runs after the you/vera pair is on disk and makes no model call; a raise rode out as a 500 and the retry re-sent a persisted text. The reply is now served without the label, traceback logged. Gate: 1449 passed, 35 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
SessionRegistry.close()and.converse()let the authoring call raise straight through the route. FastAPI answeredInternal Server Erroras text, the shell'sr.json()threw, the End button offered "connection lost, try again" over a server that was up, the sitting stayed live, and every retry paid for one more identical failure. The handoff names it: the last thing a learner sees at the moment the product tries to land.What changed (540f101)
unwindSayhands her words back; the turn claim is released so the retry is real.except Exception, notexcept ModelError: the ceiling arrives as ModelError, but a 401 or a 529 arrives as the SDK's own class, since_TimedMessages._timedwraps onlyBudgetExceeded. The worker's net is broad for the same reason, and the close test is parametrized over a plainRuntimeErrorand aModelErrorso a narrowing cannot pass silently.The review round (c0460af)
Isolated T2 review at 540f101: three lenses (escape paths, learner-facing doctrine, state and concurrency), each executing its claims in its own worktree, then two independent refuters per finding. Nine raw findings; six refuted as pre-existing or out of scope. Three fixed here, each behind a test watched to fail first:
voice.egress_safe_replyagainst the lost exp, ModelError-only catch) still escaped as a 500. One net now covers the author call and that screen; nothing is persisted before either.Recorded, not fixed, all pre-existing:
voice.closeandvoice.sitting_closeserve the same "took a position" static on a refusal or leak with no stop_reason in hand; the nudge's "Try again" loops identically once the ceiling has fired;close()takes no turn claim (two concurrent End clicks both pay the author, benign);_end_sittingsits outside the net so a store failure at the very end still 500s with the sitting live and a retry possible.Verified
Ten tests across the two commits, each watched to fail on the escaping exception or the 500 before its fix. Two of them are over HTTP with
raise_server_exceptions=False, so the 500 itself is what fails. Nothing in index.html changed; the shell already renders both the nudge and the close kinds.felix gatepass: 1449 passed, 35 skipped.Tier T2: a learner sees it. The reviewer executed the claims rather than reading the diff.