🔒 Remove hardcoded database credentials in setup_db.sh - #9
Conversation
- Replace hardcoded `DB_USER` and `DB_PASS` with environment variable lookups. - Add a mandatory check for the `DB_PASS` environment variable. - Update `DB_HOST` and `DB_PORT` to be configurable via environment variables or positional arguments. - Maintain original defaults for `DB_USER` and `DB_PORT` to ensure backward compatibility. Co-authored-by: LeandroPG19 <151863062+LeandroPG19@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What:
Fixed the hardcoded database credentials in the
setup_db.shscript.Hardcoding credentials, even in setup scripts, is a security risk as users often deploy with default values, leading to unauthorized database access.
🛡️ Solution:
contraseñaand now require it to be passed via theDB_PASSenvironment variable.DB_PASSis not set.DB_USER,DB_HOST,DB_PORT) while keeping the original defaults for backward compatibility.PR created automatically by Jules for task 16425616181098118153 started by @LeandroPG19