feat: comprehensive revenue sharing enhancements#200
Merged
BigBen-7 merged 1 commit intoLead-Studios:mainfrom Mar 29, 2026
Merged
Conversation
Closes Lead-Studios#196, Lead-Studios#197, Lead-Studios#198, Lead-Studios#199 Key changes: - Stakeholder persistence (Issue Lead-Studios#196) - Calculation history (Issue Lead-Studios#197) - Multi-currency support (Issue Lead-Studios#198) - Comprehensive unit tests (Issue Lead-Studios#199)
|
@Cybermaxi7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
BigBen-7
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements four major feature and stability enhancements for the
RevenueSharingService, transitioning it from a static calculation tool to a robust, persistent, and multi-currency enabled financial module.Key Features
1. Stakeholder Persistence (Closes #196)
stakeholdersPostgres table to store event-specific revenue splits.RevenueSharingServiceto fetch configurations from the database with a fallback to hardcoded defaults.POST/GET /revenue-share/stakeholders/{event_id}) for managing stakeholders.2. Calculation History (Closes #197)
revenue_calculationsaudit table.BackgroundTasksto asynchronously persist every calculation result.GET /revenue-share/history/{event_id}) for administrative audits.3. Multi-currency Support (Closes #198)
cachetools.GET /revenue-share/exchange-rates) to view current system exchange rates.4. Arithmetic Robustness & Unit Testing (Closes #199)
POST /revenue-share/batch).Verification Results
src/revenue_sharing_service.pyandsrc/revenue_sharing_models.py.Closes
Closes #196, Closes #197, Closes #198, Closes #199