WIP: Website/sliced#501
Merged
Merged
Conversation
- Revised FAQ entries for clearer payment options and contact information. - Updated home page to streamline location details and enhance user navigation. - Removed redundant sections from association and become_member pages, focusing on essential information. - Centralized Google Maps embed functionality to avoid duplication across pages. - Added new shared partial for map embedding to improve maintainability. - Implemented tests to ensure content accuracy and prevent regressions in public-facing pages.
- Deleted `todo.md` and `ux_audit_2025_01.md` as they are no longer relevant to the current project scope. - These files were previously merged from other sources and have been superseded by updated documentation practices. Made-with: Cursor
- Changed the address from "27 bis allée Maurice Sarraut, Toulouse" to "97 bis Boulevard de Suisse, 31200 Toulouse" in the FAQ, home, become member, and contact us pages. - Updated map embed caption to indicate the new location and removed references to the old address. - Adjusted tests to ensure the new address is correctly displayed and that the map embed functionality is centralized. This update enhances clarity and consistency in public-facing content.
- Added Leaflet map controller to manage map rendering and resizing dynamically. - Updated CSS to ensure proper display of Leaflet maps, including adjustments for image sizing and container properties. - Modified global animations to prevent conflicts with Leaflet's rendering, ensuring smooth fade-in effects. - Centralized map embed functionality in shared partials to maintain consistency across pages. - Updated tests to validate the presence of the interactive map and ensure no duplicate embeds occur. This update improves the clarity and functionality of the map feature across the application.
Made-with: Cursor
Made-with: Cursor
- Revised text across multiple pages including association, become_member, contact_us, faq, privacy_policy, and terms to enhance clarity and user understanding. - Adjusted headings, descriptions, and pricing details to better reflect the offerings and improve readability. - Streamlined language to ensure consistency in tone and presentation across the site. This update aims to provide a clearer and more engaging experience for users navigating the site.
…ience - Revised FAQ entries across multiple pages, including contact_us and become_member, to improve clarity and engagement. - Updated question phrasing and answers to provide more concise and relevant information. - Adjusted layout and styling for better readability and visual appeal, including changes to the opening hours display. - Removed outdated FAQ partial to streamline content management. This update aims to create a more user-friendly experience by ensuring that information is easily accessible and clearly presented.
- Added `skip_before_action` for the `latest` action in `BlogsController` to allow unauthenticated access. - Extended `skip_before_action` in `EventsController` to include `past` events, enabling public access to past event listings. This update improves user accessibility to blog and event content without requiring authentication for specific actions.
… improved user experience - Updated the home page title and adjusted text sizes for better visibility. - Refined the layout of the footer, including spacing adjustments and improved alignment for social icons. - Enhanced the opening hours display with updated padding and margin for a cleaner look. - Revised text in the footer and opening hours sections to provide clearer information and improve readability. This update aims to create a more engaging and user-friendly interface across key sections of the site.
- Swiper: horizontal touch-action, resolve pagination.el selectors - News: hero-pool carousel helper + lazy loading + dots - About: partner Swiper + refreshed partners.yml (bios, order) - Contact: embedded form variant, mobile-first fields and grid order - FAQ: spacing on narrow viewports Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
- Reformatted the case statement for determining the recipient email in the ContactsController for better readability. - Adjusted spacing in the user_mailer_spec to maintain consistent formatting. This change enhances code clarity while ensuring functionality remains intact.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f15e059fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…essibility and layout consistency - Added scroll margin adjustments to the header and articles for better navigation. - Removed duplicate ID from the first article to ensure unique identifiers. These changes enhance the accessibility and overall layout of the association page.
- Sanitize return_to / after_authentication_url (same host, no GET /session) - Login success: single redirect 303; form disables Turbo to keep cookie flow - Dev-only quick login + navbar visibility; revoke granter on sign out - Resync seed passwords in dev/test; circographe:seed_system_accounts task Made-with: Cursor
- Person#most_recent_membership; card shows lapsed vs none vs active - Extract active contributions partial; settings/users layout + nav shortcuts - Roleable humanization FR; request specs for users#show CTAs Made-with: Cursor
- Remove Dev::QuickLogin (routes, controller, views) and navbar hook - Harden sessions: ignore blank cookie id, align delete opts, safe terminate - Embed settings account panel on users#show; /settings redirects to #account - Add coordinates partial; trim profile shortcuts; update locales and seeds - Extend request specs for sessions, profile, settings, and admin access Made-with: Cursor
- Update session retrieval to delete cookie if session is not found, improving security and cookie management. - Ensure that a nil session returns a clean state for subsequent authentication checks.
Force RAILS_ENV to test and fail fast when specs run in another environment to prevent accidental runs against the wrong database. Made-with: Cursor
Add a development incident logger and wire it to DB health checks, critical table deletes, and failed system account logins to speed up local debugging. Made-with: Cursor
Drop cookies linked to missing/deleted users and remove a user's active sessions when archiving to prevent stale authentication state. Made-with: Cursor
Dotenv can inherit DATABASE_URL from `.env.local` into test runs; combined with RSpec suite teardown against SQLite this wiped development.sqlite3 and left FactoryBot emails like [email protected] on what developers assumed was seed data. Made-with: Cursor
Updated the seeds to improve organization and clarity. Introduced environment variables for verbose output and bulk user creation. Enhanced membership assignment logic, including specific cases for users based on their email. Added methods for better handling of seed data and progress reporting. Improved the overall readability and maintainability of the seed files.
Updated the seeds to improve organization and clarity. Introduced environment variables for verbose output and bulk user creation. Enhanced membership assignment logic, including specific cases for users based on their email. Added methods for better handling of seed data and progress reporting. Improved the overall readability and maintainability of the seed files.
Introduced a new partial view for displaying contribution options in the admin panel. This view allows admins to present available contribution formulas to users, including pricing and session details. Added conditional messaging for users without a valid membership, enhancing user experience and clarity in the purchasing process.
Resolve conflicts: keep contributions upgrade route and Admin::ContributionsController; merge contribution formula UI, i18n (catalog/formula + admin.contributions), seeds with ui_showcase; consolidate docs vocabulary; regenerate Gemfile.lock; remove obsolete action_buttons and contribution_upgrades controller. Co-authored-by: Cursor <[email protected]>
Updated the users_controller to ensure proper loading of user context. Added error handling to redirect to the users list with an alert if a user is not found. Enhanced seed data methods for upgrading memberships and recording donations, improving clarity and maintainability in the seed files.
Co-authored-by: Cursor <[email protected]>
Resolve conflicts: keep Stimulus controllers and current forms; apply page-container-wide, payment-modal, health report grid, metric cards, opening-hours select styling, settings container. Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
Clear Rails.cache after each POST /sessions example so Action Controller rate_limit counters do not leak across randomized order. Assert the signed auth cookie name (session_id) used by Authentication concern. Co-authored-by: Cursor <[email protected]>
…tion Action Controller rate_limit shares Rails.cache across the suite; clearing only after POST /sessions was not enough on CI ordering. Reset cache in the global rspec before hook alongside Faker unique reset. Co-authored-by: Cursor <[email protected]>
…eate tmp directory Modified the CI workflow to set the CI environment variable and adjusted the RSpec command to include progress formatting. Additionally, ensured the temporary directory for test results is created before running the tests.
…er functionality - Introduced a `has_many` association for `account_claims` in the `Person` model with dependent restrictions. - Updated the `AccountMerger` service to include methods for merging account claims and member number histories. - Added tests to ensure account claims and member number histories are transferred correctly during the merge process.
Updated the test database configuration to disable seeding during test runs. This change ensures that tests run against an empty database, maintaining transactional fixture isolation and improving CI reliability.
- Upgraded Docker actions in CI workflows to use version 4 for setup-buildx and version 7 for build-push. - Removed the deprecated ci-tests workflow file to streamline CI configuration.
…te lint-audit workflow - Added a new CI workflow (`ci-dev.yml`) for the `dev` branch that includes linting, security checks, and testing jobs running in parallel. - Removed the outdated `ci-lint-audit.yml` workflow to streamline CI processes. - Updated references in documentation to reflect the new CI workflow structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.