Skip to content

Filter non-resident $DATA by ADS name + improve VCN warnings. #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lazza merged 1 commit into from
Mar 10, 2026
Merged

Filter non-resident $DATA by ADS name + improve VCN warnings. #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions recuperabit/fs/ntfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,10 +341,22 @@ def content_iterator(self, partition: 'NTFSPartition', image: Any, datas: List[D
if diff > 0:
# We do not try to fill with zeroes as this might produce huge useless files
logging.warning(
u'Missing part for {}, {} clusters skipped'.format(self, diff)
u'Missing part for {} expected VCN {}, '
u'got start_VCN={} ({} clusters skipped). '.format(
self, vcn, attr['start_VCN'], diff,
)
)
vcn += diff
yield b''
elif diff < 0:
# VCN went backwards: overlap, out-of-order, or cross-stream contamination
logging.warning(
u'$DATA attribute VCN overlap for {}. '
u'expected VCN {}, got start_VCN={}. '
u'This may indicate attribute filtering error or MFT corruption.'.format(
self, vcn, attr['start_VCN']
)
)

clusters_pos = 0
size = attr['real_size']
Expand Down Expand Up @@ -430,13 +442,13 @@ def get_content(self, partition: 'NTFSPartition') -> Optional[Union[bytes, Itera
'attribute(s) for {}'.format(self))
return None
non_resident = sorted(
(d for d in attrs['$DATA'] if d['non_resident']),
(d for d in datas if d['non_resident']),
key=lambda x: x['start_VCN']
)
if len(non_resident) != len(datas):
logging.warning(
u'Found leftover resident $DATA attributes for '
'{}'.format(self)
'{}. Only those non-resident parts will be restored.'.format(self)
)
return self.content_iterator(partition, image, non_resident)

Expand Down